You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Qianyi951015 (via GitHub)" <gi...@apache.org> on 2023/02/14 03:56:36 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #24153: Make ALTER DEFAULT SHARDING STRATEGY support `NoneShardingStrategy` TYPE
Qianyi951015 opened a new pull request, #24153:
URL: https://github.com/apache/shardingsphere/pull/24153
For #23835.
Changes proposed in this pull request:
- Make ALTER DEFAULT SHARDING STRATEGY support `NoneShardingStrategy` TYPE
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #24153: Make ALTER DEFAULT SHARDING STRATEGY support `NoneShardingStrategy` TYPE
Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #24153:
URL: https://github.com/apache/shardingsphere/pull/24153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24153: Make ALTER DEFAULT SHARDING STRATEGY support `NoneShardingStrategy` TYPE
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24153:
URL: https://github.com/apache/shardingsphere/pull/24153#issuecomment-1429097818
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24153?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24153](https://codecov.io/gh/apache/shardingsphere/pull/24153?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6adc0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c236c86d5db833f71602a345292fc662f34f478c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c236c86) will **increase** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head eb6adc0 differs from pull request most recent head 561a3bb. Consider uploading reports for the commit 561a3bb to get more accurate results
```diff
@@ Coverage Diff @@
## master #24153 +/- ##
=========================================
Coverage 50.12% 50.12%
Complexity 1578 1578
=========================================
Files 3259 3259
Lines 53505 53510 +5
Branches 9840 9843 +3
=========================================
+ Hits 26818 26822 +4
- Misses 24328 24330 +2
+ Partials 2359 2358 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...l/parser/core/ShardingDistSQLStatementVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/24153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2Rpc3RzcWwvcGFyc2VyL2NvcmUvU2hhcmRpbmdEaXN0U1FMU3RhdGVtZW50VmlzaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../AlterDefaultShardingStrategyStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/24153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvZGlzdHNxbC9oYW5kbGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9kaXN0c3FsL2hhbmRsZXIvdXBkYXRlL0FsdGVyRGVmYXVsdFNoYXJkaW5nU3RyYXRlZ3lTdGF0ZW1lbnRVcGRhdGVyLmphdmE=) | `94.00% <100.00%> (+2.51%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org