You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/30 10:00:29 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #17900: Remove all deprecation warnings in providers

mik-laj commented on a change in pull request #17900:
URL: https://github.com/apache/airflow/pull/17900#discussion_r698356649



##########
File path: tests/always/test_project_structure.py
##########
@@ -163,37 +163,24 @@ class TestGoogleProviderProjectStructure(unittest.TestCase):
     }
 
     MISSING_EXAMPLES_FOR_OPERATORS = {
-        # Deprecated operator. Ignore it.
+        # Deprecated operators
         'airflow.providers.google.cloud.operators.cloud_storage_transfer_service'
         '.CloudDataTransferServiceS3ToGCSOperator',
-        # Deprecated operator. Ignore it.
         'airflow.providers.google.cloud.operators.cloud_storage_transfer_service'
         '.CloudDataTransferServiceGCSToGCSOperator',
-        # Deprecated operator. Ignore it.
         'airflow.providers.google.cloud.sensors.gcs.GCSObjectsWtihPrefixExistenceSensor',
-        # Base operator. Ignore it.
         'airflow.providers.google.cloud.operators.cloud_sql.CloudSQLBaseOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocSubmitHadoopJobOperator',
         'airflow.providers.google.cloud.operators.dataproc.DataprocInstantiateInlineWorkflowTemplateOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocScaleClusterOperator',
-        # Base operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocJobBaseOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocSubmitSparkJobOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocSubmitSparkSqlJobOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocSubmitHiveJobOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocSubmitPigJobOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.dataproc.DataprocSubmitPySparkJobOperator',
         'airflow.providers.google.cloud.operators.mlengine.MLEngineTrainingCancelJobOperator',
-        # Deprecated operator. Ignore it
         'airflow.providers.google.cloud.operators.mlengine.MLEngineManageModelOperator',
-        # Deprecated operator. Ignore it

Review comment:
       Now it is not easy to tell for operators that there are no examples. What do you think to create some variables to break down these operators?
   ```
   BASE_OPERATORS = ['AAA', 'BB']
   DEPRECATED_OPERATORS = ['AAA', 'BB']
   MISSING_EXAMPLES_FOR_OPERATORS = [
     *BASE_OPERATORS, *DEPRECATED_OPERATORS,
     'CC', 'DD',
   ]
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org