[GitHub] [incubator-iceberg] rdsr commented on a change in pull request #331: Refactor tests for metrics for reuse

[GitBox <gi...@apache.org>]

rdsr commented on a change in pull request #331: Refactor tests for metrics for reuse
URL: https://github.com/apache/incubator-iceberg/pull/331#discussion_r309348221
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -231,6 +231,19 @@ project(':iceberg-core') {
       exclude group: 'org.slf4j', module: 'slf4j-log4j12'
     }
   }
+
+  task testJar(type: Jar){
+    archiveClassifier = 'tests'
+    from sourceSets.test.output
+  }
+
+  configurations {
 
 Review comment:
   We've define `testArtifacts` configuration in `iceberg-hive` as well. I think it makes sense to define in under `allprojects` or `subprojects` once.  Same for `testJar`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org