You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by "Jan Høydahl (Jira)" <ji...@apache.org> on 2022/03/24 18:54:00 UTC

[jira] [Resolved] (SOLR-12619) Don't use ECMAScript6 in Admin UI

     [ https://issues.apache.org/jira/browse/SOLR-12619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Høydahl resolved SOLR-12619.
--------------------------------
    Resolution: Won't Fix

I think we should be fine now, yes. Closing

> Don't use ECMAScript6 in Admin UI
> ---------------------------------
>
>                 Key: SOLR-12619
>                 URL: https://issues.apache.org/jira/browse/SOLR-12619
>             Project: Solr
>          Issue Type: Bug
>          Components: Admin UI
>            Reporter: Jan Høydahl
>            Priority: Major
>
> Spinoff from SOLR-8207
> Since we don't traspile our JS but send it straight to endusers browsers, we should make sure to stay on language level 5 of JS/ES.
> In [stream.js|https://github.com/apache/lucene-solr/blob/e2521b2a8baabdaf43b92192588f51e042d21e97/solr/webapp/web/js/angular/controllers/stream.js#L97], the keyword {{let}} is used which is an ES6 feature. [~dpgove] will you have a look? This is code from 2006 so probably most users have modern browsers, but still..
> We should also look through rest of JS for similar warnings.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org