You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2016/12/08 00:56:44 UTC
[01/12] cordova-plugin-dialogs git commit: Make sure the alert
buttonLabel is a string
Repository: cordova-plugin-dialogs
Updated Branches:
refs/heads/1.3.x fef904c72 -> 233aff26f
Make sure the alert buttonLabel is a string
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/5ecb3506
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/5ecb3506
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/5ecb3506
Branch: refs/heads/1.3.x
Commit: 5ecb3506e0de87d0465713857af132e68c543f00
Parents: 7c4a5de
Author: Kevin Boosten <ke...@qnh.nl>
Authored: Tue Aug 16 09:34:00 2016 +0200
Committer: Kevin Boosten <ke...@qnh.nl>
Committed: Tue Aug 16 09:34:00 2016 +0200
----------------------------------------------------------------------
www/notification.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/5ecb3506/www/notification.js
----------------------------------------------------------------------
diff --git a/www/notification.js b/www/notification.js
index 4db8f0f..751f4ce 100644
--- a/www/notification.js
+++ b/www/notification.js
@@ -39,7 +39,7 @@ module.exports = {
alert: function(message, completeCallback, title, buttonLabel) {
var _message = (typeof message === "string" ? message : JSON.stringify(message));
var _title = (typeof title === "string" ? title : "Alert");
- var _buttonLabel = (buttonLabel || "OK");
+ var _buttonLabel = (typeof buttonLabel === "string" ? buttonLabel : "OK");
exec(completeCallback, null, "Notification", "alert", [_message, _title, _buttonLabel]);
},
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[02/12] cordova-plugin-dialogs git commit: Added test for [windows]
CB-11281 when called without defaultText
Posted by sh...@apache.org.
Added test for [windows] CB-11281 when called without defaultText
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/02a42425
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/02a42425
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/02a42425
Branch: refs/heads/1.3.x
Commit: 02a424255b601a64fc2c5d5c4f5ff4b31a0cd5c5
Parents: ece39a0
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Fri Sep 9 13:38:33 2016 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Fri Sep 9 13:38:33 2016 -0700
----------------------------------------------------------------------
tests/tests.js | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/02a42425/tests/tests.js
----------------------------------------------------------------------
diff --git a/tests/tests.js b/tests/tests.js
index 7056c0d..fc1dea4 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -185,6 +185,10 @@ exports.defineManualTests = function (contentEl, createActionButton) {
promptDialog('You pressed prompt.', 'Prompt Dialog', ['Yes', 'No', 'Maybe, Not Sure'],'Default Text');
}, 'prompt');
+ createActionButton('Prompt Dialog - no default', function () {
+ promptDialog('You pressed prompt.', 'Prompt Dialog', ['Yes', 'No']);
+ }, 'prompt');
+
createActionButton('Built-in Alert Dialog', function () {
if (typeof alert === 'function') {
alert('You pressed alert');
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[04/12] cordova-plugin-dialogs git commit: Merge branch 'master' of
https://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs
Posted by sh...@apache.org.
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/9a19139e
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/9a19139e
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/9a19139e
Branch: refs/heads/1.3.x
Commit: 9a19139eefb0981a178f531cd502bfdd08233c83
Parents: 542e7f7 02a4242
Author: Steve Gill <st...@gmail.com>
Authored: Fri Sep 9 16:27:11 2016 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Fri Sep 9 16:27:11 2016 -0700
----------------------------------------------------------------------
tests/tests.js | 4 ++++
1 file changed, 4 insertions(+)
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[08/12] cordova-plugin-dialogs git commit: Merge branch 'master' of
https://github.com/Boosten/cordova-plugin-dialogs
Posted by sh...@apache.org.
Merge branch 'master' of https://github.com/Boosten/cordova-plugin-dialogs
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/137fa7c8
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/137fa7c8
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/137fa7c8
Branch: refs/heads/1.3.x
Commit: 137fa7c84cc909577584a9f55ca1f37e9db031b7
Parents: d34092c 5ecb350
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Fri Sep 9 17:26:06 2016 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Fri Sep 9 17:26:06 2016 -0700
----------------------------------------------------------------------
www/notification.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[07/12] cordova-plugin-dialogs git commit: Close #86
Posted by sh...@apache.org.
Close #86
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/d34092cd
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/d34092cd
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/d34092cd
Branch: refs/heads/1.3.x
Commit: d34092cd37c386b02d836c9cac5c14b38415e111
Parents: 68ceff4
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Fri Sep 9 16:34:23 2016 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Fri Sep 9 16:34:23 2016 -0700
----------------------------------------------------------------------
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[10/12] cordova-plugin-dialogs git commit: Close #43
Posted by sh...@apache.org.
Close #43
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/baee8130
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/baee8130
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/baee8130
Branch: refs/heads/1.3.x
Commit: baee8130920a74514fd809808b1939b3fbfa94af
Parents: 2b73248
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Fri Sep 9 17:45:36 2016 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Fri Sep 9 17:45:36 2016 -0700
----------------------------------------------------------------------
----------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[12/12] cordova-plugin-dialogs git commit: CB-12224 Updated version
and RELEASENOTES.md for release 1.3.1
Posted by sh...@apache.org.
CB-12224 Updated version and RELEASENOTES.md for release 1.3.1
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/233aff26
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/233aff26
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/233aff26
Branch: refs/heads/1.3.x
Commit: 233aff26f8102d25ed531518c83c4e2be7127bdf
Parents: 6606fcb
Author: Shazron Abdullah <sh...@apache.org>
Authored: Wed Dec 7 16:39:44 2016 -0800
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Wed Dec 7 16:39:44 2016 -0800
----------------------------------------------------------------------
RELEASENOTES.md | 193 ++++++++++++++++++++++++++++++++++++++++++++++++++
package.json | 2 +-
plugin.xml | 2 +-
tests/plugin.xml | 2 +-
4 files changed, 196 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/233aff26/RELEASENOTES.md
----------------------------------------------------------------------
diff --git a/RELEASENOTES.md b/RELEASENOTES.md
index 2b34048..476ba7e 100644
--- a/RELEASENOTES.md
+++ b/RELEASENOTES.md
@@ -20,6 +20,199 @@
-->
# Release Notes
+### 1.3.1 (Dec 07, 2016)
+* [CB-11917](https://issues.apache.org/jira/browse/CB-11917) - Remove pull request template checklist item: "iCLA has been submitted\u2026"
+* Close #43
+* Replace empty buttonLabel with 'OK'
+* Make sure the alert buttonLabel is a string
+* Close #86
+* Fix dumb linting error
+* Add enter key handling and map to default button.
+* Added test for [windows] [CB-11281](https://issues.apache.org/jira/browse/CB-11281) when called without defaultText
+* [CB-11832](https://issues.apache.org/jira/browse/CB-11832) Incremented plugin version.
+* [CB-11832](https://issues.apache.org/jira/browse/CB-11832) Updated version and RELEASENOTES.md for release 1.3.0
+* [CB-11832](https://issues.apache.org/jira/browse/CB-11832) updated missing header file
+* Select the text and put default value in the input directly.
+* [CB-11281](https://issues.apache.org/jira/browse/CB-11281) windows: defaultText is not taken as input if no input by user fixed
+* Separated CSS from JS code. Fixed the prompt dialog CSS to look close to native. Fixed the positioning of the prompt dialog for Windows. Fixed minor JSHint issues.
+* [CB-11795](https://issues.apache.org/jira/browse/CB-11795) Add 'protective' entry to cordovaDependencies
+* [CB-8773](https://issues.apache.org/jira/browse/CB-8773) Fix for iOS 8 keyboard not appearing on prompt
+* [CB-11677](https://issues.apache.org/jira/browse/CB-11677) Android: made text, entered to prompt dialog visible
+* Closing stale pull request: close #78
+* CB-8947:(ios) Fix crash. Convert non-string messages to strings. Added tests.
+* Add badges for paramedic builds on Jenkins
+* Closing stale PRs. This closes #77
+* Add pull request template.
+* [CB-11218](https://issues.apache.org/jira/browse/CB-11218) Convert button list to appropriate type
+* Simply add Browser to supported platforms
+* [CB-10996](https://issues.apache.org/jira/browse/CB-10996) Adding front matter to README.md
+* [CB-11091](https://issues.apache.org/jira/browse/CB-11091) Incremented plugin version.
+* Updated version and RELEASENOTES.md for release 1.2.1
+* Closing stale pull request: close #57
+* [CB-10097](https://issues.apache.org/jira/browse/CB-10097) dialog doesn't show on iOS when called from a select list onChange event
+* Remove 'warning' emoji, as it doesn't correctly display in the docs website: http://cordova.apache.org/docs/en/dev/cordova-plugin-dialogs/index.html
+* [CB-10727](https://issues.apache.org/jira/browse/CB-10727) Dialogs plugin has warnings on iOS
+* [CB-10636](https://issues.apache.org/jira/browse/CB-10636) Add JSHint for plugins
+* chore: edit package.json license to match SPDX id
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Incremented plugin version.
+* Update notification.js
+* Close conflicted/duplicate/stale pull requests. This closes #27. Closes #54. Closes #6.
+* add JIRA issue tracker link
+* Allow a blank string for dialog titles and messages.
+* correct block usage
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) linked issues in RELEASENOTES.md
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated version and RELEASENOTES.md for release 1.2.0
+* removed r prefix from tags
+* [CB-10035](https://issues.apache.org/jira/browse/CB-10035) Updated RELEASENOTES to be newest to oldest
+* [CB-8549](https://issues.apache.org/jira/browse/CB-8549) Updated source to pass Fortify scan.
+* Actually fixing the contribute link.
+* Fixing contribute link.
+* add CSS class to prompt div for windows platform
+* [CB-9347](https://issues.apache.org/jira/browse/CB-9347) - fix to allow to stack multiple UIAlertControllers
+* [CB-9347](https://issues.apache.org/jira/browse/CB-9347) - fix to allow to stack multiple UIAlertControllers
+* remove travis-ci
+* [CB-9192](https://issues.apache.org/jira/browse/CB-9192) Incremented plugin version.
+* [CB-9202](https://issues.apache.org/jira/browse/CB-9202) updated repo url to github mirror in package.json
+* [CB-9192](https://issues.apache.org/jira/browse/CB-9192) Updated version and RELEASENOTES.md for release 1.1.1
+* [CB-9128](https://issues.apache.org/jira/browse/CB-9128) cordova-plugin-dialogs documentation translation: cordova-plugin-dialogs
+* fix npm md
+* [CB-8959](https://issues.apache.org/jira/browse/CB-8959) Incremented plugin version.
+* [CB-8959](https://issues.apache.org/jira/browse/CB-8959) Updated version and RELEASENOTES.md for release 1.1.0
+* [CB-8928](https://issues.apache.org/jira/browse/CB-8928) Removed direct call to toStaticHTML, only call it if we are sure it's present. This closes #52
+* [CB-7734](https://issues.apache.org/jira/browse/CB-7734) - "navigator.notification.alert" or "navigator.notification.confirm" seem have a "many words" issue. (closes #39)
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Incremented plugin version.
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Updated version in package.json for release 1.0.0
+* Revert "CB-8858 Incremented plugin version."
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Incremented plugin version.
+* [CB-8858](https://issues.apache.org/jira/browse/CB-8858) Updated version and RELEASENOTES.md for release 1.0.0
+* [CB-8746](https://issues.apache.org/jira/browse/CB-8746) gave plugin major version bump
+* [CB-8683](https://issues.apache.org/jira/browse/CB-8683) updated wp and bb specific references of old id to new id
+* [CB-8683](https://issues.apache.org/jira/browse/CB-8683) changed plugin-id to pacakge-name
+* [CB-8653](https://issues.apache.org/jira/browse/CB-8653) properly updated translated docs to use new id
+* [CB-8653](https://issues.apache.org/jira/browse/CB-8653) updated translated docs to use new id
+* Use TRAVIS_BUILD_DIR, install paramedic by npm
+* [CB-8653](https://issues.apache.org/jira/browse/CB-8653) Updated Readme
+* [CB-8659](https://issues.apache.org/jira/browse/CB-8659) ios: 4.0.x Compatibility: Remove use of deprecated headers
+* [CB-8565](https://issues.apache.org/jira/browse/CB-8565) Integrate TravisCI
+* [CB-8438](https://issues.apache.org/jira/browse/CB-8438) cordova-plugin-dialogs documentation translation: cordova-plugin-dialogs
+* [CB-8538](https://issues.apache.org/jira/browse/CB-8538) Added package.json file
+* [CB-8367](https://issues.apache.org/jira/browse/CB-8367) [org.apache.cordova.dialogs] Add Prompt support on Windows
+* [CB-8429](https://issues.apache.org/jira/browse/CB-8429) Incremented plugin version.
+* [CB-8429](https://issues.apache.org/jira/browse/CB-8429) Updated version and RELEASENOTES.md for release 0.3.0
+* Add missing license header to www/browser/notification.js
+* Correct way to specify Windows platform in config.xml
+* [CB-8351](https://issues.apache.org/jira/browse/CB-8351) Use argumentForIndex rather than NSArray extension
+* [CB-7955](https://issues.apache.org/jira/browse/CB-7955) Add support "browser" platform
+* [CB-8110](https://issues.apache.org/jira/browse/CB-8110) Incremented plugin version.
+* [CB-8110](https://issues.apache.org/jira/browse/CB-8110) Updated version and RELEASENOTES.md for release 0.2.11
+* [CB-7737](https://issues.apache.org/jira/browse/CB-7737) lower min height for alert
+* [CB-8038](https://issues.apache.org/jira/browse/CB-8038) backslash getting escaped twice in bb10
+* [CB-8029](https://issues.apache.org/jira/browse/CB-8029) test 1-based indexing for confirm
+* [CB-7639](https://issues.apache.org/jira/browse/CB-7639) Update docs + manual tests
+* [CB-7639](https://issues.apache.org/jira/browse/CB-7639) Revert back isAlertShowing flag in case of exception to prevent queuing of future dialogs.
+* [CB-7639](https://issues.apache.org/jira/browse/CB-7639) Handle button labels as array on windows
+* [CB-7977](https://issues.apache.org/jira/browse/CB-7977) Mention deviceready in plugin docs
+* Check for setTextDirection API level
+* [android] Make spinner dialog to use THEME_DEVICE_DEFAULT_LIGHT (same as the other dialogs)
+* [Android] Unbreak API level < 14
+* [CB-7414](https://issues.apache.org/jira/browse/CB-7414) BB10 Document callback parameter for navigator.notification.alert
+* [CB-7700](https://issues.apache.org/jira/browse/CB-7700) cordova-plugin-dialogs documentation translation: cordova-plugin-dialogs
+* [CB-7571](https://issues.apache.org/jira/browse/CB-7571) Bump version of nested plugin to match parent plugin
+* [CB-7571](https://issues.apache.org/jira/browse/CB-7571) Incremented plugin version.
+* [CB-7571](https://issues.apache.org/jira/browse/CB-7571) Updated version and RELEASENOTES.md for release 0.2.10
+* [CB-7538](https://issues.apache.org/jira/browse/CB-7538) Android beep thread fix Beep now executes in it's own thread. It was previously executing in the main UI thread which was causing the application to lock up will the beep was occurring. Closing pull request
+* Set dialog text dir to locale
+* Renamed test dir, added nested plugin.xml
+* [CB-7244](https://issues.apache.org/jira/browse/CB-7244) Incremented plugin version.
+* [CB-7244](https://issues.apache.org/jira/browse/CB-7244) Updated version and RELEASENOTES.md for release 0.2.9
+* ubuntu: pass proper arguments to prompt callback
+* ubuntu: use TextField instead of TextInput
+* ubuntu: proper message escaping before passing to qml
+* update notification.js
+* added documentation for manual tests
+* [CB-6965](https://issues.apache.org/jira/browse/CB-6965) Added manual tests
+* CB-6127lisa7cordova-plugin-consolecordova-plugin-dialogs documentation translation: cordova-plugin-dialogs
+* android: Explicitly apply default theme to dialogs
+* Fix Beep exception on Android when no argument passed
+* documentation translation: cordova-plugin-dialogs
+* Lisa testing pulling in plugins for plugin: cordova-plugin-dialogs
+* Lisa testing pulling in plugins for plugin: cordova-plugin-dialogs
+* [CB-6965.](https://issues.apache.org/jira/browse/CB-6965.) Port notification tests to test-framework
+* Add comment about other implementation.
+* [CB-6877](https://issues.apache.org/jira/browse/CB-6877) Incremented plugin version.
+* [CB-6877](https://issues.apache.org/jira/browse/CB-6877) Updated version and RELEASENOTES.md for release 0.2.8
+* [CB-6801](https://issues.apache.org/jira/browse/CB-6801) Add license
+* running original windows.open, inAppBrowser is overriding it no need to place CSS in every page anymore
+* [CB-5945](https://issues.apache.org/jira/browse/CB-5945) [Windows8] do not call success callbacks until dialog is dismissed
+* [CB-4616](https://issues.apache.org/jira/browse/CB-4616) Returned index 0 was not documented for notification.prompt
+* update docs to state that prompt is supported on windowsphone
+* [CB-6528](https://issues.apache.org/jira/browse/CB-6528) allow scroll on alert message content
+* [CB-6628][amazon-fireos]dialogs plugin's confirm and prompt methods dont work confirm() method was missing amazon-fireos platform check. added that. prompt() method had bug. It is executed in a worker thread that does not have a message queue(or Looper object) associated with it and hence "can't create a handler" exception is thrown. To fix this issue, we need to create the EditText widget from within the UI thread. This was fixed sometime ago when we added fireos platform but commit got lost somewhere. So fixing it again now.
+* [CB-6491](https://issues.apache.org/jira/browse/CB-6491) add CONTRIBUTING.md
+* Added check for isFinishing() on the parent activity to prevent crashes when trying to display dialogs when activity is in this phase of it's lifecycle
+* [CB-4966](https://issues.apache.org/jira/browse/CB-4966) Dialogs are in window now No need to add anything to manifest or index.html
+* Removing FirefoxOS Quirks * no need to add special permission (it's different API with the same name) * notification.css is added automatically
+* [CB-6452](https://issues.apache.org/jira/browse/CB-6452) Incremented plugin version on dev branch.
+* [CB-6452](https://issues.apache.org/jira/browse/CB-6452) Updated version and RELEASENOTES.md for release 0.2.7
+* [CB-6460](https://issues.apache.org/jira/browse/CB-6460) Update license headers
+* [CB-6422](https://issues.apache.org/jira/browse/CB-6422) [windows8] use cordova/exec/proxy
+* [CB-6411](https://issues.apache.org/jira/browse/CB-6411) [BlackBerry10] Work around Audio playback issue
+* [CB-6411](https://issues.apache.org/jira/browse/CB-6411) [BlackBerry10] Updates to beep
+* [CB-6212](https://issues.apache.org/jira/browse/CB-6212) iOS: fix warnings compiled under arm64 64-bit
+* Add NOTICE file
+* [CB-5980](https://issues.apache.org/jira/browse/CB-5980) Incremented plugin version on dev branch.
+* [CB-5980](https://issues.apache.org/jira/browse/CB-5980) Updated version and RELEASENOTES.md for release 0.2.6
+* fixing index + prompt response
+* no need to recreate the manifest.webapp file after each `cordova prepare`
+* FFOS description added
+* Delete stale test/ directory
+* [CB-5719](https://issues.apache.org/jira/browse/CB-5719) Incremented plugin version on dev branch.
+* [CB-5719](https://issues.apache.org/jira/browse/CB-5719) Updated version and RELEASENOTES.md for release 0.2.5
+* [CB-4696](https://issues.apache.org/jira/browse/CB-4696) Fix compile error for Xcode 4.5.
+* [CB-5658](https://issues.apache.org/jira/browse/CB-5658) Update license comment formatting of doc/index.md
+* [CB-5658](https://issues.apache.org/jira/browse/CB-5658) Add doc.index.md for Dialogs plugin
+* [CB-5658](https://issues.apache.org/jira/browse/CB-5658) Delete stale snapshot of plugin docs
+* [CB-3762](https://issues.apache.org/jira/browse/CB-3762) Change prompt default to empty string
+* move images from css to img
+* [CB-2682](https://issues.apache.org/jira/browse/CB-2682) [CB-2683](https://issues.apache.org/jira/browse/CB-2683) add prompt dialog to Notification API for WP
+* [CB-5565](https://issues.apache.org/jira/browse/CB-5565) Incremented plugin version on dev branch.
+* [CB-5565](https://issues.apache.org/jira/browse/CB-5565) Updated version and RELEASENOTES.md for release 0.2.4
+* add ubuntu platform
+* 1. Added amazon-fireos platform. 2. Change to use amazon-fireos as a platform if user agent string contains 'cordova-amazon-fireos'.
+* added beep funtionality using ms-winsoundevent:Notfication.Default
+* [CB-5188](https://issues.apache.org/jira/browse/CB-5188)
+* [CB-5188](https://issues.apache.org/jira/browse/CB-5188) Updated version and RELEASENOTES.md for release 0.2.3
+* [CB-5128](https://issues.apache.org/jira/browse/CB-5128) added repo + issue tag to plugin.xml for dialogs plugin
+* new plugin execute arguments supported
+* new plugin style
+* smaller fonts styling input
+* img files copied inside plugin
+* style added
+* prompt added
+* styling from James
+* fixed "exec" calls addedd css, but not working yet
+* first (blind) try
+* [CB-4915](https://issues.apache.org/jira/browse/CB-4915) Incremented plugin version on dev branch.
+* [CB-4915](https://issues.apache.org/jira/browse/CB-4915) Updated version and RELEASENOTES.md for release 0.2.2
+* [CB-4889](https://issues.apache.org/jira/browse/CB-4889) bumping&resetting version
+* [windows8] commandProxy was moved
+* [CB-4889](https://issues.apache.org/jira/browse/CB-4889) renaming reference in Notification.cs
+* [CB-4889](https://issues.apache.org/jira/browse/CB-4889) renaming org.apache.cordova.core.dialogs to org.apache.cordova.dialogs
+* Rename CHANGELOG.md -> RELEASENOTES.md
+* [CB-4592](https://issues.apache.org/jira/browse/CB-4592) [Blackberry10] Added beep support
+* [CB-4752](https://issues.apache.org/jira/browse/CB-4752) Incremented plugin version on dev branch.
+* [CB-4592](https://issues.apache.org/jira/browse/CB-4592) [Blackberry10] Added beep support
+* Add empty CHANGELOG.md
+* [CB-4595](https://issues.apache.org/jira/browse/CB-4595) updated version
+* [CB-4417](https://issues.apache.org/jira/browse/CB-4417) Move cordova-plugin-dialogs to its own Java package.
+* updated namespace
+* updated readme
+* [plugin.xml] standardizing license + meta
+* [license] adding apache license file
+* updating plugin.xml with registry data
+* [Windows8] added windows8 support
+* [CB-4359](https://issues.apache.org/jira/browse/CB-4359) Dialogs plugin needs to specify AudioToolbox.framework dependency in plugin.xml
+
### 1.3.0 (Sep 08, 2016)
* [CB-11832](https://issues.apache.org/jira/browse/CB-11832) updated missing header file
* Select the text and put default value in the input directly.
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/233aff26/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 2a38e9f..1fb3abd 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-dialogs",
- "version": "1.3.1-dev",
+ "version": "1.3.1",
"description": "Cordova Notification Plugin",
"cordova": {
"id": "cordova-plugin-dialogs",
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/233aff26/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 8cf9c37..719f0e7 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
id="cordova-plugin-dialogs"
- version="1.3.1-dev">
+ version="1.3.1">
<name>Notification</name>
<description>Cordova Notification Plugin</description>
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/233aff26/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index 7edf3bc..f40db26 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -20,7 +20,7 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
id="cordova-plugin-dialogs-tests"
- version="1.3.1-dev">
+ version="1.3.1">
<name>Cordova Notification Plugin Tests</name>
<license>Apache 2.0</license>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[06/12] cordova-plugin-dialogs git commit: Add enter key handling and
map to default button.
Posted by sh...@apache.org.
Add enter key handling and map to default button.
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/5ebefa82
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/5ebefa82
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/5ebefa82
Branch: refs/heads/1.3.x
Commit: 5ebefa82d5220b4525602b3c38e9198095f80d8c
Parents: 9a19139
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Fri Sep 9 16:05:38 2016 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Fri Sep 9 16:30:51 2016 -0700
----------------------------------------------------------------------
src/windows/NotificationProxy.js | 7 +++++++
1 file changed, 7 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/5ebefa82/src/windows/NotificationProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/NotificationProxy.js b/src/windows/NotificationProxy.js
index 2d32f83..e826557 100644
--- a/src/windows/NotificationProxy.js
+++ b/src/windows/NotificationProxy.js
@@ -116,6 +116,13 @@ function createPromptDialog(title, message, buttons, defaultText, callback) {
// make sure input field is under focus
dlg.querySelector('#prompt-input').select();
+ // add Enter/Return key handling
+ var defaultButton = dlg.querySelector(".dlgButtonFirst");
+ dlg.addEventListener("keypress",function(e) {
+ if (e.keyCode === 13) { // enter key
+ defaultButton && defaultButton.click();
+ }
+ });
return dlgWrap;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[11/12] cordova-plugin-dialogs git commit: CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…"
Posted by sh...@apache.org.
CB-11917 - Remove pull request template checklist item: "iCLA has been submitted\u2026"
This closes #87
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/6606fcb6
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/6606fcb6
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/6606fcb6
Branch: refs/heads/1.3.x
Commit: 6606fcb6389be8973eeed1d30166fb7e34505496
Parents: baee813
Author: Shazron Abdullah <sh...@gmail.com>
Authored: Wed Sep 28 01:33:44 2016 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Tue Oct 4 21:36:06 2016 -0700
----------------------------------------------------------------------
.github/PULL_REQUEST_TEMPLATE.md | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/6606fcb6/.github/PULL_REQUEST_TEMPLATE.md
----------------------------------------------------------------------
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 4bd6da9..91582f4 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -17,7 +17,6 @@ Thanks!
### Checklist
-- [ ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[09/12] cordova-plugin-dialogs git commit: Replace empty buttonLabel
with 'OK'
Posted by sh...@apache.org.
Replace empty buttonLabel with 'OK'
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/2b732482
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/2b732482
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/2b732482
Branch: refs/heads/1.3.x
Commit: 2b732482a5cf9dc4814dcb22cf5fc6a94ee652ba
Parents: 137fa7c
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Fri Sep 9 17:37:07 2016 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Fri Sep 9 17:37:07 2016 -0700
----------------------------------------------------------------------
www/notification.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/2b732482/www/notification.js
----------------------------------------------------------------------
diff --git a/www/notification.js b/www/notification.js
index 751f4ce..b6d4d39 100644
--- a/www/notification.js
+++ b/www/notification.js
@@ -39,7 +39,7 @@ module.exports = {
alert: function(message, completeCallback, title, buttonLabel) {
var _message = (typeof message === "string" ? message : JSON.stringify(message));
var _title = (typeof title === "string" ? title : "Alert");
- var _buttonLabel = (typeof buttonLabel === "string" ? buttonLabel : "OK");
+ var _buttonLabel = (buttonLabel && typeof buttonLabel === "string" ? buttonLabel : "OK");
exec(completeCallback, null, "Notification", "alert", [_message, _title, _buttonLabel]);
},
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[05/12] cordova-plugin-dialogs git commit: Fix dumb linting error
Posted by sh...@apache.org.
Fix dumb linting error
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/68ceff4d
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/68ceff4d
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/68ceff4d
Branch: refs/heads/1.3.x
Commit: 68ceff4d0ef5c5de9144d09d7a05712c439951c1
Parents: 5ebefa8
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Fri Sep 9 16:27:49 2016 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Fri Sep 9 16:30:51 2016 -0700
----------------------------------------------------------------------
src/windows/NotificationProxy.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/68ceff4d/src/windows/NotificationProxy.js
----------------------------------------------------------------------
diff --git a/src/windows/NotificationProxy.js b/src/windows/NotificationProxy.js
index e826557..c5bc272 100644
--- a/src/windows/NotificationProxy.js
+++ b/src/windows/NotificationProxy.js
@@ -120,7 +120,9 @@ function createPromptDialog(title, message, buttons, defaultText, callback) {
var defaultButton = dlg.querySelector(".dlgButtonFirst");
dlg.addEventListener("keypress",function(e) {
if (e.keyCode === 13) { // enter key
- defaultButton && defaultButton.click();
+ if(defaultButton) {
+ defaultButton.click();
+ }
}
});
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[03/12] cordova-plugin-dialogs git commit: CB-11832 Incremented
plugin version.
Posted by sh...@apache.org.
CB-11832 Incremented plugin version.
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/commit/542e7f7c
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/tree/542e7f7c
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/diff/542e7f7c
Branch: refs/heads/1.3.x
Commit: 542e7f7c9f9b5a6d9af48f71549c7d988f91145a
Parents: fef904c
Author: Steve Gill <st...@gmail.com>
Authored: Fri Sep 9 16:08:04 2016 -0700
Committer: Steve Gill <st...@gmail.com>
Committed: Fri Sep 9 16:08:04 2016 -0700
----------------------------------------------------------------------
package.json | 2 +-
plugin.xml | 2 +-
tests/plugin.xml | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/542e7f7c/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index f85f14c..2a38e9f 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-dialogs",
- "version": "1.3.0",
+ "version": "1.3.1-dev",
"description": "Cordova Notification Plugin",
"cordova": {
"id": "cordova-plugin-dialogs",
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/542e7f7c/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 1069cce..8cf9c37 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -20,7 +20,7 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
id="cordova-plugin-dialogs"
- version="1.3.0">
+ version="1.3.1-dev">
<name>Notification</name>
<description>Cordova Notification Plugin</description>
http://git-wip-us.apache.org/repos/asf/cordova-plugin-dialogs/blob/542e7f7c/tests/plugin.xml
----------------------------------------------------------------------
diff --git a/tests/plugin.xml b/tests/plugin.xml
index 55675b2..7edf3bc 100644
--- a/tests/plugin.xml
+++ b/tests/plugin.xml
@@ -20,7 +20,7 @@
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
id="cordova-plugin-dialogs-tests"
- version="1.3.0">
+ version="1.3.1-dev">
<name>Cordova Notification Plugin Tests</name>
<license>Apache 2.0</license>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org