You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhangshenghang (via GitHub)" <gi...@apache.org> on 2026/07/10 01:00:28 UTC
[PR] [Fix][Core] Exclude Scala classes from Spark starter [seatunnel]
zhangshenghang opened a new pull request, #11393:
URL: https://github.com/apache/seatunnel/pull/11393
## What does this PR do?
Fixes #10881.
The Spark starter shaded Scala classes from both the direct Scala dependency and already-shaded SeaTunnel dependencies. In YARN cluster mode, those classes can conflict with the Scala runtime provided by the Spark distribution and cause Scala signature errors.
This change excludes Scala classes and stale signature metadata from Spark starter artifacts. It also adds a packaging integration test that verifies the Spark 3 starter jar does not contain `scala/` entries.
## Validation
- `./mvnw -pl seatunnel-core/seatunnel-spark-starter/seatunnel-spark-3-starter -am verify -DskipUT=true -DskipIT=false -Dit.test=SparkStarterJarContentIT -DfailIfNoTests=false`
- `./mvnw -q -DskipTests verify`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Core] Exclude Scala classes from Spark starter [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11393:
URL: https://github.com/apache/seatunnel/pull/11393#issuecomment-4950909897
Rechecked the current merge gate after my approval.
My source-side conclusion is unchanged: I still do not see a reopened Daniel-side blocker in the Spark starter shading diff. The CI fact has changed, though: the aggregate `Build` is no longer just pending/ongoing on this head; the current check run is now cancelled.
Current gate details:
```text
Apache aggregate check
-> Build: cancelled
-> https://github.com/apache/seatunnel/runs/86597995417
-> fork workflow run: zhangshenghang/seatunnel/actions/runs/29173343906
-> failed job: Run / all-connectors-it-1 (8, ubuntu-latest)
-> failed job: Run / kafka-connector-it (11, ubuntu-latest)
-> cancelled siblings: Run / kudu-connector-it (8, ubuntu-latest), Run / kafka-connector-it (8, ubuntu-latest), Run / paimon-connector-it (11, ubuntu-latest)
```
These lanes do not line up with this PR's starter-jar shading/test surface, and this branch is now behind the latest `dev` by 3 commits (`compare status: diverged`, `ahead_by=4`, `behind_by=3`). I also checked the current `dev` head, but its aggregate Build is still pending right now, so I cannot point to a confirmed upstream fix yet. The lowest-cost next step is to sync with the latest `dev` and rerun `Build` first.
My earlier approval still reflects the current source diff. If the same unrelated lanes keep failing after the sync, please paste the rerun links here and I can help narrow them down further.
### Merge conclusion: source approved, waiting for CI
Blocking items: none from Daniel's current source review.
Current merge gate: cancelled unrelated CI lanes above; please sync latest `dev` and rerun first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Core] Exclude Scala classes from Spark starter [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11393:
URL: https://github.com/apache/seatunnel/pull/11393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Core] Exclude Scala classes from Spark starter [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11393:
URL: https://github.com/apache/seatunnel/pull/11393#issuecomment-4957131102
Rechecked the latest head: the source-level blocker from my previous Daniel round is still closed for me, and the current `Build` gate is now green on this unchanged head.
At this point I do not see a new code-side blocker from Daniel on this revision. For queue bookkeeping, this branch is still `diverged` against the latest `dev` (`ahead_by=4`, `behind_by=8`), but because the required `Build` signal is green now, I am not asking for a sync-only retry from Daniel's side here.
If the repository still needs a write-capable maintainer to refresh the formal review state or dismiss an older visible `changes requested` entry, that final gate may need to be handled separately from Daniel's source-level recheck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Core] Exclude Scala classes from Spark starter [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11393:
URL: https://github.com/apache/seatunnel/pull/11393#issuecomment-4968430543
Rechecked the same unchanged head `f7840be7d976` after the CI / merge-gate fact changed.
## Runtime path rechecked
```text
Apache aggregate check
-> Build: cancelled
-> https://github.com/apache/seatunnel/runs/86597995417
-> fork workflow run: zhangshenghang/seatunnel/actions/runs/29173343906
-> failed job: Run / all-connectors-it-1 (8, ubuntu-latest)
-> failed job: Run / kafka-connector-it (11, ubuntu-latest)
-> cancelled siblings: Run / kudu-connector-it (8, ubuntu-latest), Run / kafka-connector-it (8, ubuntu-latest), Run / paimon-connector-it (11, ubuntu-latest)
```
## Merge conclusion
### Conclusion: source blocker cleared from Daniel's side
1. Blocking items
- None from Daniel's source review on this unchanged head.
2. Current gate
- The current CI signal is now green: https://github.com/apache/seatunnel/actions/runs/29173344457/job/86670647621
- Daniel only has `READ` permission on this repository, so GitHub may still show earlier review state and a write-capable maintainer may still need to handle the final approval / dismissal step.
I do not see a reopened code-side blocker from Daniel on the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Fix][Core] Exclude Scala classes from Spark starter [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11393:
URL: https://github.com/apache/seatunnel/pull/11393#issuecomment-4944526693
Rechecked the current unchanged head `5510f2ce353f` again.
My earlier source-side blocker on this same revision still stands from Daniel's side. Separately, this branch is also behind the latest `dev` (`compare status: diverged`, `behind_by=1`), and the current red `Build` signal does not look actionable on top of this stale head yet.
So at this point I would treat the next steps as two separate gates:
1. the existing source-side blocker on the current head still needs to be fixed
2. please sync the latest `dev` and rerun CI first using the current failing run as the reference point here:
https://github.com/apache/seatunnel/actions/runs/29081335402/job/86324629152
If the updated head is still red after the sync, please paste the new failing check link and I can help narrow it down against the refreshed revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org