[GitHub] [lucene-solr] dweiss commented on a change in pull request #2382: LUCENE-9780: Only validate JARs for tasks that are enabled

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #2382:
URL: https://github.com/apache/lucene-solr/pull/2382#discussion_r577409452



##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -333,9 +333,14 @@ configure([project(":solr"), project(":lucene"),]) {
     }
 
     doFirst {
-      def allReferenced = validationTasks.collectMany { task ->
-        task.project.jarInfos.collectMany { it.referencedFiles }
-      }.collect { it.toString() }
+      def allReferenced = validationTasks
+          .findAll { task ->

Review comment:
       Can you add a commend linking to the issue and perhaps shorten to:
   {code}
   // Only collect for enabled tasks: https://issues.apache.org/jira/browse/LUCENE-9780
   .findAll { it.enabled }
   .collectMany...
   {code}




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org