Re: [PR] Add integration test for log4j-samples-jlink module [logging-log4j-samples]

["vy (via GitHub)" <gi...@apache.org>]

vy commented on code in PR #393:
URL: https://github.com/apache/logging-log4j-samples/pull/393#discussion_r3129663213


##########
log4j-samples-jlink/pom.xml:
##########
@@ -52,9 +58,77 @@
       <scope>runtime</scope>
     </dependency>
 
+    <!-- TEST -->
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>

Review Comment:
   Nope, please use JUnit 5.



##########
log4j-samples-jlink/pom.xml:
##########
@@ -52,9 +58,77 @@
       <scope>runtime</scope>
     </dependency>
 
+    <!-- TEST -->
+    <dependency>
+      <groupId>junit</groupId>
+      <artifactId>junit</artifactId>
+      <scope>test</scope>
+    </dependency>
+
   </dependencies>
+
   <build>
     <plugins>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-antrun-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>prepare-integration-test-logs</id>
+            <goals>
+              <goal>run</goal>
+            </goals>
+            <phase>pre-integration-test</phase>
+            <configuration>
+              <target>
+                <mkdir dir="${project.build.directory}/logs" />
+                <delete file="${project.build.directory}/logs/out.log" />
+              </target>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+
+      <!-- ✅ FIXED HERE -->

Review Comment:
   Please remove all this LLM crap.



##########
log4j-samples-jlink/pom.xml:
##########
@@ -30,6 +32,12 @@
   <properties>
     <!-- Plugin version -->
     <maven-jlink-plugin.version>3.2.0</maven-jlink-plugin.version>
+
+    <!-- OS-specific launcher suffix -->
+    <launcher.suffix />

Review Comment:
   Can we rename this to `jlink.launcher.suffix`, please?



##########
log4j-samples-jlink/pom.xml:
##########
@@ -64,6 +138,23 @@
           <launcher>log4j-samples-jlink=org.apache.logging.log4j.samples.jlink/org.apache.logging.log4j.samples.jlink.Main</launcher>
         </configuration>
       </plugin>
+
     </plugins>
   </build>
+
+  <!-- ✅ Windows profile -->

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org