[GitHub] [hive] rbalamohan commented on a change in pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF

[GitBox <gi...@apache.org>]

rbalamohan commented on a change in pull request #2242:
URL: https://github.com/apache/hive/pull/2242#discussion_r629967730



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java
##########
@@ -885,20 +885,7 @@ public void process(Writable value) throws HiveException {
             batchCounter++;
             oneRootOperator.process(deserializerBatch, 0);
 
-            /**
-             * Only reset the current data columns.  Not any data columns defaulted to NULL
-             * because they are not present in the partition, and not partition columns.
-             */
-            for (int c = 0; c < currentDataColumnCount; c++) {
-              ColumnVector colVector = deserializerBatch.cols[c];
-              if (colVector != null) {
-                colVector.reset();
-                colVector.init();
-              }
-            }
-            deserializerBatch.selectedInUse = false;
-            deserializerBatch.size = 0;
-            deserializerBatch.endOfFile = false;
+            deserializerBatch.reset();

Review comment:
       After reset, can you reinit isNull and isRepeating for columns which are not present in currentDataColumnCount? 
   (i.e similar to the case mentioned in https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java#L706)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org