You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/02 15:35:19 UTC
[GitHub] [kafka] ijuma commented on a change in pull request #10247: MINOR: Fix log format in AbstractCoordinator
ijuma commented on a change in pull request #10247:
URL: https://github.com/apache/kafka/pull/10247#discussion_r585668358
##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -860,7 +860,7 @@ public void onSuccess(ClientResponse resp, RequestFuture<Void> future) {
@Override
public void onFailure(RuntimeException e, RequestFuture<Void> future) {
- log.debug("FindCoordinator request failed due to {}", e);
+ log.debug("FindCoordinator request failed due to {}", e.getMessage());
Review comment:
It's not clear what was intended here. Is the stacktrace useful or not? If the `{}` is removed, then the stacktrace would be printed. If we make the change in this PR, we don't include the stacktrace. @hachikuji Thoughts since you have done a lot of coordinator debugging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org