You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Ruben Q L (Jira)" <ji...@apache.org> on 2024/02/05 08:14:00 UTC
[jira] [Updated] (CALCITE-5647) RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq)
[ https://issues.apache.org/jira/browse/CALCITE-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ruben Q L updated CALCITE-5647:
-------------------------------
Summary: RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq) (was: RelMdPopulationSize calls rel.estimateRowCount instead of mq.getRowCount)
> RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq)
> --------------------------------------------------------------------------------------
>
> Key: CALCITE-5647
> URL: https://issues.apache.org/jira/browse/CALCITE-5647
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.34.0
> Reporter: Adam Kennedy
> Assignee: Adam Kennedy
> Priority: Minor
> Labels: pull-request-available
> Original Estimate: 1h
> Time Spent: 20m
> Remaining Estimate: 40m
>
> A few locations in Calcite call rel.estimateRowCount(mq) when they should instead call mq.getRowCount(red).
> We detected this because we implemented row count estimation entirely within an alternative handle instead of RelMdRowCount, and then override estimateRowCount to ensure the custom handler is user, by throwing an unreachable code exception.
> A few places in Calcite trigger these unreachable exceptions because they do not use mq.getRowCount.
> The most easily triggered on is in RelMdPopulationSize for the Values parameter.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)