[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #3635: ARTEMIS-2007 - allow redistribution if there are unmatched messages p…

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #3635:
URL: https://github.com/apache/activemq-artemis/pull/3635#discussion_r662524506



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -2920,6 +2922,10 @@ private boolean deliver() {
       // Either the iterator is empty or the consumer is busy
       int noDelivery = 0;
 
+      // track filters not matching, used to track when all consumers can't match, redistribution is then an option
+      int numNoMatch = 0;
+      final int consumerCount = this.consumers.size();

Review comment:
       Between here and the sync block a consumer could be added or removed and thus the count and logic within sync block would be broke. This probably should be in the sync block to avoid this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org