You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org> on 2007/03/12 16:17:09 UTC
[jira] Created: (ADFFACES-408) encode urls that are in the
generated css file
encode urls that are in the generated css file
----------------------------------------------
Key: ADFFACES-408
URL: https://issues.apache.org/jira/browse/ADFFACES-408
Project: MyFaces ADF-Faces
Issue Type: Bug
Reporter: Jeanne Waldman
Assigned To: Jeanne Waldman
The css file that gets generated from the skinning css file may contain urls, like background-image: url("/skins/purple/error.png");
We need to run these through the encodeResourceURL method.
The use case I have is when a portlet is running in an iframe inside a portal and we want to the portlet's urls to point to the portal's server:
==> Portal's CSS /WebCenter-ViewController-context-root/afr/sort_asc_n.png
==> Portlet's CSS /adf-richclient-demo/afr/sort_asc_n.png
The second URL points to nowhere as such app is not in the portal's (parent)
application server.
If we encode the urls that we write out to the generated css file, this problem should be fixed. I am about to test it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-408) encode urls that are in the
generated css file
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman updated ADFFACES-408:
------------------------------------
Component/s: Skinning
> encode urls that are in the generated css file
> ----------------------------------------------
>
> Key: ADFFACES-408
> URL: https://issues.apache.org/jira/browse/ADFFACES-408
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
>
> The css file that gets generated from the skinning css file may contain urls, like background-image: url("/skins/purple/error.png");
> We need to run these through the encodeResourceURL method.
> The use case I have is when a portlet is running in an iframe inside a portal and we want to the portlet's urls to point to the portal's server:
> ==> Portal's CSS /WebCenter-ViewController-context-root/afr/sort_asc_n.png
> ==> Portlet's CSS /adf-richclient-demo/afr/sort_asc_n.png
> The second URL points to nowhere as such app is not in the portal's (parent)
> application server.
> If we encode the urls that we write out to the generated css file, this problem should be fixed. I am about to test it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-408) encode urls that are in the
generated css file
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-408:
----------------------------------------
Affects Version/s: 1.0.1-incubating-core-SNAPSHOT
> encode urls that are in the generated css file
> ----------------------------------------------
>
> Key: ADFFACES-408
> URL: https://issues.apache.org/jira/browse/ADFFACES-408
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
>
> The css file that gets generated from the skinning css file may contain urls, like background-image: url("/skins/purple/error.png");
> We need to run these through the encodeResourceURL method.
> The use case I have is when a portlet is running in an iframe inside a portal and we want to the portlet's urls to point to the portal's server:
> ==> Portal's CSS /WebCenter-ViewController-context-root/afr/sort_asc_n.png
> ==> Portlet's CSS /adf-richclient-demo/afr/sort_asc_n.png
> The second URL points to nowhere as such app is not in the portal's (parent)
> application server.
> If we encode the urls that we write out to the generated css file, this problem should be fixed. I am about to test it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-408) encode urls that are in the
generated css file
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481310 ]
Jeanne Waldman commented on ADFFACES-408:
-----------------------------------------
I committed this to trunk. revision 518725
> encode urls that are in the generated css file
> ----------------------------------------------
>
> Key: ADFFACES-408
> URL: https://issues.apache.org/jira/browse/ADFFACES-408
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
>
> The css file that gets generated from the skinning css file may contain urls, like background-image: url("/skins/purple/error.png");
> We need to run these through the encodeResourceURL method.
> The use case I have is when a portlet is running in an iframe inside a portal and we want to the portlet's urls to point to the portal's server:
> ==> Portal's CSS /WebCenter-ViewController-context-root/afr/sort_asc_n.png
> ==> Portlet's CSS /adf-richclient-demo/afr/sort_asc_n.png
> The second URL points to nowhere as such app is not in the portal's (parent)
> application server.
> If we encode the urls that we write out to the generated css file, this problem should be fixed. I am about to test it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ADFFACES-408) encode urls that are in the
generated css file
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeanne Waldman resolved ADFFACES-408.
-------------------------------------
Resolution: Fixed
> encode urls that are in the generated css file
> ----------------------------------------------
>
> Key: ADFFACES-408
> URL: https://issues.apache.org/jira/browse/ADFFACES-408
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Affects Versions: 1.0.1-incubating-core-SNAPSHOT
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
>
> The css file that gets generated from the skinning css file may contain urls, like background-image: url("/skins/purple/error.png");
> We need to run these through the encodeResourceURL method.
> The use case I have is when a portlet is running in an iframe inside a portal and we want to the portlet's urls to point to the portal's server:
> ==> Portal's CSS /WebCenter-ViewController-context-root/afr/sort_asc_n.png
> ==> Portlet's CSS /adf-richclient-demo/afr/sort_asc_n.png
> The second URL points to nowhere as such app is not in the portal's (parent)
> application server.
> If we encode the urls that we write out to the generated css file, this problem should be fixed. I am about to test it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-408) encode urls that are in the
generated css file
Posted by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481311 ]
Jeanne Waldman commented on ADFFACES-408:
-----------------------------------------
Here's my log comment:
ADFFACES-408 encode urls that are in the generated css file
I refactored SkinStyleSheetParserUtils.java so that the url is in one spot in the code and I can easily call encodeResourceURL on it.
I changed the base-desktop.xss urls to not start with ../.. They should start with '/' if they want to be context relative.
I added code to the PropertyNodeParser.java to encodeResourceURLs for urls found in xss files.
> encode urls that are in the generated css file
> ----------------------------------------------
>
> Key: ADFFACES-408
> URL: https://issues.apache.org/jira/browse/ADFFACES-408
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Skinning
> Reporter: Jeanne Waldman
> Assigned To: Jeanne Waldman
>
> The css file that gets generated from the skinning css file may contain urls, like background-image: url("/skins/purple/error.png");
> We need to run these through the encodeResourceURL method.
> The use case I have is when a portlet is running in an iframe inside a portal and we want to the portlet's urls to point to the portal's server:
> ==> Portal's CSS /WebCenter-ViewController-context-root/afr/sort_asc_n.png
> ==> Portlet's CSS /adf-richclient-demo/afr/sort_asc_n.png
> The second URL points to nowhere as such app is not in the portal's (parent)
> application server.
> If we encode the urls that we write out to the generated css file, this problem should be fixed. I am about to test it out.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.