Re: [PR] [CELEBORN-1046] Add an expiration time configuration for app directory to clean up [incubator-celeborn]

["SteNicholas (via GitHub)" <gi...@apache.org>]

SteNicholas commented on code in PR #1998:
URL: https://github.com/apache/incubator-celeborn/pull/1998#discussion_r1361773283


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2083,6 +2084,14 @@ object CelebornConf extends Logging {
       .intConf
       .createWithDefault(16)
 
+  val WORKER_STORAGE_EXPIRE_DIR_TIMEOUT: ConfigEntry[Long] =
+    buildConf("celeborn.worker.storage.expireDirs.timeout")
+      .categories("worker")
+      .version("0.3.1")
+      .doc(s"The timeout for a expire dirs to be deleted on disk.")
+      .timeConf(TimeUnit.MILLISECONDS)
+      .createWithDefaultString("6h")

Review Comment:
   Why is the default value of `celeborn.worker.storage.expireDirs.timeout` 6h?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org