You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/09/05 09:47:39 UTC

Re: Review Request 62062: RANGER-1763:The logic of the expansion button in the Edit Policy page is error. The user must click twice to collapse Conditions.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62062/
-----------------------------------------------------------

(Updated 九月 5, 2017, 9:47 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Summary (updated)
-----------------

RANGER-1763:The logic of the expansion button in the Edit Policy page is error. The user must click twice to collapse Conditions.


Bugs: RANGER-1763
    https://issues.apache.org/jira/browse/RANGER-1763


Repository: ranger


Description (updated)
-------

Like reports page, the expansion button in the Edit Policy page shuold be "hide" instead of "show" when the condition table was expanded.


Diffs
-----

  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5db 


Diff: https://reviews.apache.org/r/62062/diff/2/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 62062: RANGER-1763:The logic of the expansion button in the Edit Policy page is error. The user must click twice to collapse Conditions.

Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62062/#review184626
-----------------------------------------------------------


Ship it!




Ship It!

- Nitin Galave


On Sept. 5, 2017, 9:54 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62062/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2017, 9:54 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1763
>     https://issues.apache.org/jira/browse/RANGER-1763
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Like reports page, the expansion button in the Edit Policy page shuold be "hide" instead of "show" when the condition table was expanded.
> Please refer to reports-page.png and edit-policy-page.png in RANGER-1763.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5db 
> 
> 
> Diff: https://reviews.apache.org/r/62062/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


Re: Review Request 62062: RANGER-1763:The logic of the expansion button in the Edit Policy page is error. The user must click twice to collapse Conditions.

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62062/#review184531
-----------------------------------------------------------


Ship it!




Ship It!

- Qiang Zhang


On 九月 5, 2017, 9:54 a.m., pengjianhua wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62062/
> -----------------------------------------------------------
> 
> (Updated 九月 5, 2017, 9:54 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1763
>     https://issues.apache.org/jira/browse/RANGER-1763
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Like reports page, the expansion button in the Edit Policy page shuold be "hide" instead of "show" when the condition table was expanded.
> Please refer to reports-page.png and edit-policy-page.png in RANGER-1763.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5db 
> 
> 
> Diff: https://reviews.apache.org/r/62062/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengjianhua
> 
>


Re: Review Request 62062: RANGER-1763:The logic of the expansion button in the Edit Policy page is error. The user must click twice to collapse Conditions.

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62062/
-----------------------------------------------------------

(Updated 九月 5, 2017, 9:54 a.m.)


Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.


Bugs: RANGER-1763
    https://issues.apache.org/jira/browse/RANGER-1763


Repository: ranger


Description (updated)
-------

Like reports page, the expansion button in the Edit Policy page shuold be "hide" instead of "show" when the condition table was expanded.
Please refer to reports-page.png and edit-policy-page.png in RANGER-1763.


Diffs
-----

  security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 6f27d5db 


Diff: https://reviews.apache.org/r/62062/diff/2/


Testing
-------


Thanks,

pengjianhua