You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/03 16:34:35 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #13683: [CMake][OpenCL] Remove warning for OpenCL wrapper
Lunderberg opened a new pull request, #13683:
URL: https://github.com/apache/tvm/pull/13683
Previously, setting `set(USE_OPENCL ON)` would result in a warning, stating that the runtime wrapper for OpenCL would be used. Since this is the desired behavior when OpenCL support is enabled, and is not something that a user should fix, this commit removes the warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #13683: [CMake][OpenCL] Remove warning for OpenCL wrapper
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #13683:
URL: https://github.com/apache/tvm/pull/13683#issuecomment-1373756385
@tvm-bot rerun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13683: [CMake][OpenCL] Remove warning for OpenCL wrapper
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13683:
URL: https://github.com/apache/tvm/pull/13683#issuecomment-1369978462
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @echuraev, @elvin-n <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #13683: [CMake][OpenCL] Remove warning for OpenCL wrapper
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #13683:
URL: https://github.com/apache/tvm/pull/13683#issuecomment-1377408015
> I have added this warning message especially to notify the user that the OpenCL wrapper will be used, and it might lead to a runtime error if the OpenCL library doesn't exist on a target device.
Good point, as that is a runtime error that would occur on first usage, whereas all the other library dependencies would cause a failure when importing `libtvm_runtime.so`.
> If warning message might embarrass, let's keep just status message?
I like this idea, and have the message back in, but with `message(STATUS ...)` instead of `message(WARNING ...)`. I also adjusted the wording of the message to make it clear what the wrapper does (runtime search for library) and not just that a wrapper exists. Could you check that the updated wording is accurate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #13683: [CMake][OpenCL] Remove warning for OpenCL wrapper
Posted by GitBox <gi...@apache.org>.
masahi merged PR #13683:
URL: https://github.com/apache/tvm/pull/13683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13683: [CMake][OpenCL] Remove warning for OpenCL wrapper
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13683:
URL: https://github.com/apache/tvm/pull/13683#issuecomment-1369978452
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @echuraev, @elvin-n <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on a diff in pull request #13683: [CMake][OpenCL] Remove warning for OpenCL wrapper
Posted by GitBox <gi...@apache.org>.
echuraev commented on code in PR #13683:
URL: https://github.com/apache/tvm/pull/13683#discussion_r1065945134
##########
cmake/modules/OpenCL.cmake:
##########
@@ -43,7 +43,7 @@ if(USE_OPENCL)
tvm_file_glob(GLOB RUNTIME_OPENCL_SRCS src/runtime/opencl/*.cc)
if(${USE_OPENCL} MATCHES ${IS_TRUE_PATTERN})
- message(WARNING "Build with OpenCL wrapper")
+ message(STATUS "Enabled runtime search for OpenCL installation location")
Review Comment:
I would say `library location` but installation is also ok for me.
```suggestion
message(STATUS "Enabled runtime search for OpenCL library location")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org