[GitHub] [skywalking] JaredTan95 commented on pull request #7340: Adjust the project structure of the alarm module

[GitBox <gi...@apache.org>]

JaredTan95 commented on pull request #7340:
URL: https://github.com/apache/skywalking/pull/7340#issuecomment-883048920


   > What do you mean own implementation? I don't think we would provide 2 kinds of implementations.
   > 
   > Could you provide more context?
   
   Makes it easy for users to add their own alarm implementations, It's mean that user can use `selector` to extend sw alarm logical, like :
   
   ```yaml
   alarm:
     selector: ${SW_ALARM:myAlarm}
     default:
     myAlarm:
   ```
   
   For our case, we may use `myAlarm`  to implement multi-tenant alarm logical, and we can reuse `alarm-default-plugin` core.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org