You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/10/21 21:16:02 UTC
Review Request 39521: Show a warning popup before user is about to be
logged out
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39521/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Bugs: AMBARI-13512
https://issues.apache.org/jira/browse/AMBARI-13512
Repository: ambari
Description
-------
Show a warning popup 60 seconds before user is about to be logged out. It will trigger browser user action when user is actually monitoring the screen which will make the user active again. Otherwise user will be logged out after 60 seconds.
The warning message should say:
"You will be automatically logged out in X seconds due to inactivity. [Log Out Now] [Remain Logged In]"
X should automatically count down from 60, once per second.
Popup Title:
Automatic Logout
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 2c9e1c9
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Auth.js a73c540
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/TimeoutWarning.html PRE-CREATION
ambari-web/app/controllers/main.js fb73770
ambari-web/app/messages.js 1c19b7d
Diff: https://reviews.apache.org/r/39521/diff/
Testing
-------
Manually tested on live cluster.
All unit tests passed.
10071 tests complete (10 seconds)
105 tests pending
Thanks,
Richard Zang
Re: Review Request 39521: Show a warning popup before user is about
to be logged out
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39521/#review103470
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Oct. 21, 2015, 7:16 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39521/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 7:16 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-13512
> https://issues.apache.org/jira/browse/AMBARI-13512
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Show a warning popup 60 seconds before user is about to be logged out. It will trigger browser user action when user is actually monitoring the screen which will make the user active again. Otherwise user will be logged out after 60 seconds.
> The warning message should say:
> "You will be automatically logged out in X seconds due to inactivity. [Log Out Now] [Remain Logged In]"
> X should automatically count down from 60, once per second.
> Popup Title:
> Automatic Logout
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 2c9e1c9
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Auth.js a73c540
> ambari-admin/src/main/resources/ui/admin-web/app/views/modals/TimeoutWarning.html PRE-CREATION
> ambari-web/app/controllers/main.js fb73770
> ambari-web/app/messages.js 1c19b7d
>
> Diff: https://reviews.apache.org/r/39521/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> All unit tests passed.
> 10071 tests complete (10 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 39521: Show a warning popup before user is about
to be logged out
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39521/#review103485
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Oct. 21, 2015, 10:23 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39521/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 10:23 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
>
>
> Bugs: AMBARI-13512
> https://issues.apache.org/jira/browse/AMBARI-13512
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Show a warning popup 60 seconds before user is about to be logged out. It will trigger browser user action when user is actually monitoring the screen which will make the user active again. Otherwise user will be logged out after 60 seconds.
> The warning message should say:
> "You will be automatically logged out in X seconds due to inactivity. [Log Out Now] [Remain Logged In]"
> X should automatically count down from 60, once per second.
> Popup Title:
> Automatic Logout
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 2c9e1c9
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Auth.js a73c540
> ambari-admin/src/main/resources/ui/admin-web/app/views/modals/TimeoutWarning.html PRE-CREATION
> ambari-web/app/config.js 26f0553
> ambari-web/app/controllers/main.js fb73770
> ambari-web/app/messages.js 1c19b7d
>
> Diff: https://reviews.apache.org/r/39521/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> All unit tests passed.
> 10071 tests complete (10 seconds)
> 105 tests pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 39521: Show a warning popup before user is about
to be logged out
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39521/
-----------------------------------------------------------
(Updated Oct. 21, 2015, 10:23 p.m.)
Review request for Ambari, Jaimin Jetly and Yusaku Sako.
Changes
-------
Do not show close button. Externalize remainTime for testing.
Bugs: AMBARI-13512
https://issues.apache.org/jira/browse/AMBARI-13512
Repository: ambari
Description
-------
Show a warning popup 60 seconds before user is about to be logged out. It will trigger browser user action when user is actually monitoring the screen which will make the user active again. Otherwise user will be logged out after 60 seconds.
The warning message should say:
"You will be automatically logged out in X seconds due to inactivity. [Log Out Now] [Remain Logged In]"
X should automatically count down from 60, once per second.
Popup Title:
Automatic Logout
Diffs (updated)
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/mainCtrl.js 2c9e1c9
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Auth.js a73c540
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/TimeoutWarning.html PRE-CREATION
ambari-web/app/config.js 26f0553
ambari-web/app/controllers/main.js fb73770
ambari-web/app/messages.js 1c19b7d
Diff: https://reviews.apache.org/r/39521/diff/
Testing
-------
Manually tested on live cluster.
All unit tests passed.
10071 tests complete (10 seconds)
105 tests pending
Thanks,
Richard Zang