You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:37:02 UTC
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #1117: arch/sim: Fix hostfs.h No such file or directory in makedep
patacongo commented on a change in pull request #1117:
URL: https://github.com/apache/incubator-nuttx/pull/1117#discussion_r429991892
##########
File path: arch/sim/src/Makefile
##########
@@ -38,6 +38,7 @@ include $(TOPDIR)/Make.defs
ARCH_SRCDIR = $(TOPDIR)$(DELIM)arch$(DELIM)$(CONFIG_ARCH)$(DELIM)src
+INCLUDES += ${shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)}
Review comment:
$(ARCH_SRCDIR) would be $(TOPDIR)/arch/sim/src. Why do you expect hostft.h to be there?
##########
File path: arch/sim/src/Makefile
##########
@@ -38,6 +38,7 @@ include $(TOPDIR)/Make.defs
ARCH_SRCDIR = $(TOPDIR)$(DELIM)arch$(DELIM)$(CONFIG_ARCH)$(DELIM)src
+INCLUDES += ${shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)}
Review comment:
hostfs.h is located at $(TOPDIR)/include/nuttx/hostfs.h
Or is there something else going on that is not clear?
##########
File path: arch/sim/src/Makefile
##########
@@ -38,6 +38,7 @@ include $(TOPDIR)/Make.defs
ARCH_SRCDIR = $(TOPDIR)$(DELIM)arch$(DELIM)$(CONFIG_ARCH)$(DELIM)src
+INCLUDES += ${shell $(INCDIR) "$(CC)" $(ARCH_SRCDIR)}
Review comment:
Okay, yes, I see in arch/sim/src/Makefile:
213 hostfs.h: $(TOPDIR)/include/nuttx/fs/hostfs.h
214 @echo "CP: $<"
215 $(Q) cp $< $@
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org