You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/01 19:38:41 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #12745: Optimize subclasses of DummyOperator for Scheduling

turbaszek commented on a change in pull request #12745:
URL: https://github.com/apache/airflow/pull/12745#discussion_r533672482



##########
File path: airflow/models/dagrun.py
##########
@@ -724,7 +724,7 @@ def schedule_tis(self, schedulable_tis: Iterable[TI], session: Session = None) -
             ti
             for ti in schedulable_tis
             if (
-                ti.task.task_type == "DummyOperator"
+                (ti.task.task_type == "DummyOperator" or getattr(ti.task, "_is_dummy", False))

Review comment:
       ```suggestion
                   (getattr(ti.task, "_is_dummy", False)
   ```
   Should this be enough? I think `DummyOperator` will also fall in this category




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org