You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 18:57:56 UTC

[GitHub] [airflow] mobuchowski commented on a change in pull request #15533: Expose snowflake query_id in snowflake hook and operator

mobuchowski commented on a change in pull request #15533:
URL: https://github.com/apache/airflow/pull/15533#discussion_r620567118



##########
File path: airflow/providers/snowflake/hooks/snowflake.py
##########
@@ -245,3 +247,40 @@ def set_autocommit(self, conn, autocommit: Any) -> None:
 
     def get_autocommit(self, conn):
         return getattr(conn, 'autocommit_mode', False)
+

Review comment:
       Thanks for the feedback, I agree with both points and will adjust. 
   I did not find better way than copying without changing DBApi semantics, also, when looking for similar solution saw that that's what some connectors do already - like Exasol one.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org