You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by "Xin Gong (Jira)" <ji...@apache.org> on 2024/03/18 08:04:00 UTC

[jira] [Created] (FLINK-34715) Fix mysql ut about closing BinlogSplitReader

Xin Gong created FLINK-34715:
--------------------------------

             Summary: Fix mysql ut about closing BinlogSplitReader
                 Key: FLINK-34715
                 URL: https://issues.apache.org/jira/browse/FLINK-34715
             Project: Flink
          Issue Type: Improvement
          Components: Flink CDC
            Reporter: Xin Gong
             Fix For: cdc-3.1.0


BinlogSplitReaderTest#readBinlogSplitsFromSnapshotSplits should test binlog reader is closed after binlog reader close. But code always test snapshot split reader is closed.

```java

binlogReader.close();

assertNotNull(snapshotSplitReader.getExecutorService());
assertTrue(snapshotSplitReader.getExecutorService().isTerminated());

```

We shoud change code to 

```java

binlogReader.close();

assertNotNull(binlogReader.getExecutorService());
assertTrue(binlogReader.getExecutorService().isTerminated());

```



--
This message was sent by Atlassian Jira
(v8.20.10#820010)