You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/08/26 04:41:39 UTC

[GitHub] [flink] wangyang0918 commented on pull request #20673: [BP-1.15][FLINK-28265][k8s] Make KubernetesStateHandleStore#addEntry idempotent

wangyang0918 commented on PR #20673:
URL: https://github.com/apache/flink/pull/20673#issuecomment-1228046277

   @XComp Oh, my bad. I should not introduce this concurrent issue here. Either the `callbackInvocationCount` needs to be asserted in the whenComplete, or I should execute `CompletableFuture.supplyAsync` in the direct executor.
   
   ```
   result.whenComplete(
                   (ignore, throwable) -> assertThat(callbackInvocationCount.get(), is(2)));
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org