You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/09/07 07:37:47 UTC

[GitHub] ningyu1 edited a comment on issue #2328: [BUG]ActiveLimitFilter 在消费者并发调用时不能真正限制并发数if (active >= max)与 RpcStatus.beginCount(url, methodName);操作不是原子的

ningyu1 edited a comment on issue #2328: [BUG]ActiveLimitFilter 在消费者并发调用时不能真正限制并发数if (active >= max)与 RpcStatus.beginCount(url, methodName);操作不是原子的
URL: https://github.com/apache/incubator-dubbo/issues/2328#issuecomment-419300655
 
 
   @diecui1202 @wj1369884616 
   My 'pr #2437' is a relatively small change in the old structure to ensure atomicity.
   His 'pr #2445' is replacing the while with the semaphore, which I think is good.
   I think using the semaphore is better than my repair.
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org