[GitHub] cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #918: SAMZA-2094: Implement the StartpointVisitor for the KafkaSystemConsumer.
URL: https://github.com/apache/samza/pull/918#discussion_r257058746
 
 

 ##########
 File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
 ##########
 @@ -141,11 +166,14 @@ public void start() {
 
   private void startSubscription() {
     //subscribe to all the registered TopicPartitions
-    LOG.info("{}: Consumer subscribes to {}", this, topicPartitionsToSSP.keySet());
+    Set<TopicPartition> registeredTopicPartitions = new HashSet<>();
+    registeredTopicPartitions.addAll(topicPartitionsToSSP.keySet());
+    registeredTopicPartitions.addAll(topicPartitionToStartpointMap.keySet());
 
 Review comment:
   What is the case where this has a `TopicPartition`, but `topicPartitionsToSSP` does not have it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services