You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/09/22 12:00:39 UTC
[GitHub] [carbondata] ajantha-bhat opened a new pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
ajantha-bhat opened a new pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707463119
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707087877
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707084330
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-696740401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707152498
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4391/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707087252
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2638/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-696743786
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4175/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707087176
ok, for testing, it is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707147440
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2639/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707065386
@QiangCai : It was introduced during secondary index development I guess, you can look up "isPositionIDRequested" in code. They basically use it to decide whether the position reference need to kept or removed during plan optimization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707084035
@ajantha-bhat can we remove it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-696884059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3949: [CARBONDATA-4030] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-707085109
@QiangCai : I will check, If I remove, getPositionId() Udf may not work in projection. But it was only test purpose I guess. Shall try to remove?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] QiangCai commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
QiangCai commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-706934495
why we need table property "isPositionIDRequested"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-696758152
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-696740401
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2432/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3949: [TEMP] [WIP] Fix issue in concurrent SI global sort
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3949:
URL: https://github.com/apache/carbondata/pull/3949#issuecomment-696758152
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org