You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by OrDTesters <gi...@git.apache.org> on 2018/12/04 06:47:38 UTC

[GitHub] zeppelin pull request #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so t...

GitHub user OrDTesters opened a pull request:

    https://github.com/apache/zeppelin/pull/3249

    [ZEPPELIN-3898] Adding repo in testDelRepo so test can run by itself

    ### What is this PR for?
    Test DependencyResolverTest.testDelRepo fails when run on its own. The test needs a repo to already be added so it can delete it. If the test is run on its own, the repo is not added to start and so the test fails. The proposed PR fixes this issue by having the test add the repo at the beginning.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3898

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/OrDTesters/zeppelin fix-DependencyResolverTest-testDelRepo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3249
    
----
commit 8900f23296ec9dc61f7ec37a79a3af9bd8fb0d9b
Author: OrDTesters <or...@...>
Date:   2018-12-04T06:46:01Z

    [ZEPPELIN-3898] Adding repo in testDelRepo so test can run by itself

----


---

[GitHub] zeppelin issue #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3249
  
    Thanks @OrDTesters LGTM


---

[GitHub] zeppelin issue #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can...

Posted by OrDTesters <gi...@git.apache.org>.

Github user OrDTesters commented on the issue:

    https://github.com/apache/zeppelin/pull/3249
  
    From what I can tell, the build is failing on Travis due to one job taking too long to run. I do not believe it to be related to my change.


---

[GitHub] zeppelin issue #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can...

Posted by OrDTesters <gi...@git.apache.org>.

Github user OrDTesters commented on the issue:

    https://github.com/apache/zeppelin/pull/3249
  
    If I run the command `mvn test -Dtest=DependencyResolverTest#testDelRepo` to run the test method by itself, the test fails. The proposed patch that has the test add the repo beforehand leads to the command to pass.


---

[GitHub] zeppelin issue #3249: [ZEPPELIN-3898] Adding repo in testDelRepo so test can...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3249
  
    @OrDTesters What do you mean "run on its own" ? Do you mean to run it in IDE ?


---