[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5184: Expand Splunk test coverage

["jamesnetherton (via GitHub)" <gi...@apache.org>]

jamesnetherton commented on PR #5184:
URL: https://github.com/apache/camel-quarkus/pull/5184#issuecomment-1679018595

   @JiriOndrusek Sorry, just thinking about `integration-tests/splunk/README.adoc` again. We can simplify it a bit and just have the UI accessible by default.
   
   We can modify `SplunkTestResource` and  add port `8000` to the list of exposed ports, then print a log message at the end of `SplunkTestResource.start()`. E.g something like:
   
   ```
   LOG.infof("Splunk UI running on: http://localhost:%d", container.getMappedPort(WEB_PORT));
   ```
   
   Then the `README.adoc` content can just be like:
   
   ```
   The Splunk UI is helpful for the testing as you can see (and search) for data inside Splunk. The URL to the Splunk UI is output to the console.
   
   You may want to delay the Splunk container shutdown either by adding a `Thread.sleep` into `SplunkTestResource.stop()` or commenting out `container.stop()`.
   ``` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org