You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/28 07:56:39 UTC
[GitHub] [kafka] showuon opened a new pull request #9791: KAFKA-10873: ignore warnning messages if connector/task start failed
showuon opened a new pull request #9791:
URL: https://github.com/apache/kafka/pull/9791
Ignore warning message if connector/task start failed because we already log error messages to user when start connectors/tasks failed.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon closed pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed
Posted by GitBox <gi...@apache.org>.
showuon closed pull request #9791:
URL: https://github.com/apache/kafka/pull/9791
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9791: KAFKA-10873: ignore warnning messages if connector/task start failed
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9791:
URL: https://github.com/apache/kafka/pull/9791#issuecomment-751621516
@rhauch @kkonstantine , please help review this simple PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9791:
URL: https://github.com/apache/kafka/pull/9791#issuecomment-768830962
@kkonstantine , Thanks for the comments. So you mean this issue can be kept as is? Or we should find another way to implement it instead of bookkeeping way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9791:
URL: https://github.com/apache/kafka/pull/9791#issuecomment-769632410
@kkonstantine , thanks for the comments. Good to me. Close this PR. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9791:
URL: https://github.com/apache/kafka/pull/9791#issuecomment-764474682
@rhauch @kkonstantine , please help review this simple PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #9791:
URL: https://github.com/apache/kafka/pull/9791#issuecomment-764474682
@rhauch @kkonstantine , please help review this simple PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kkonstantine commented on pull request #9791: KAFKA-10873: ignore warning messages if connector/task start failed
Posted by GitBox <gi...@apache.org>.
kkonstantine commented on pull request #9791:
URL: https://github.com/apache/kafka/pull/9791#issuecomment-769611695
The former I guess. I don't see a strong case on skipping the messages based on number of occurrences. Seems we can use this information in the log and that it should be present in abnormal circumstances (maybe with a severity that varies)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org