[GitHub] [airflow] potiuk commented on pull request #23195: Nicer handling of cached Breeze parameters

[GitBox <gi...@apache.org>]

potiuk commented on PR #23195:
URL: https://github.com/apache/airflow/pull/23195#issuecomment-1107663019

   This has been bothered me a bit - our implementation of parameter caching with synchronization was a bit convoluted (mostly because it was based on the Bash implementation). 
   
   I took a stab at it and it turned out that we can rather easily do it "properly" i.e. extending Click `Choice` to make the parameters much "smarter" -now it is enough do declare the parameter as "CacheableChoice" and it does all the between-session caching of last used values- and it even can nicely integrate with the help printed by rich-click in the way that we can see both - default and current values in the --help output"
   
   ![output-config](https://user-images.githubusercontent.com/595491/164948835-ed4e546f-9ef4-456e-9d7b-cd44936dd7ee.svg)
   
   @Bowrna -> you might want to take a look and see that this is a really nice improvement :). 
   
   @blag -> you might also take some inspiration when  convert Airlfow CLI. The Click + Rich Click combination is awesome and wonderfully and easily extensible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org