[GitHub] [spark] attilapiros commented on issue #24343: [SPARK-26953][CORE][TEST] Disable result checking in the test: java.lang.ArrayIndexOutOfBoundsException in TimSort

[GitBox <gi...@apache.org>]

attilapiros commented on issue #24343: [SPARK-26953][CORE][TEST] Disable result checking in the test: java.lang.ArrayIndexOutOfBoundsException in TimSort
URL: https://github.com/apache/spark/pull/24343#issuecomment-482101683
 
 
   Then I would suggest, something like:
   ~~~scala
       val runLongRunningCheck = false
       if (runLongRunningCheck) {
       ...
       }
   ~~~
   
   Because that way it is guaranteed the code compiles and the flag is explains what is your intention (nobody will remove as it is just unused code). 
   Even better to extract the if's body into a separate method.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org