You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/04/28 19:44:08 UTC
Review Request 20787: Patch for KAFKA-1383
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20787/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1383
https://issues.apache.org/jira/browse/KAFKA-1383
Repository: kafka
Description
-------
The interestOps is updated by the processor thread after the request is put in the request queue. There is no guarantee that after a request is dequeued, the read bit in interestOps is turned off. So need to wait a bit.
Diffs
-----
core/src/test/scala/unit/kafka/network/SocketServerTest.scala 75bd41b7d0ccbd3763e21905173f05f43f2a02f2
Diff: https://reviews.apache.org/r/20787/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 20787: Patch for KAFKA-1383
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20787/#review41614
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 28, 2014, 5:44 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20787/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 5:44 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1383
> https://issues.apache.org/jira/browse/KAFKA-1383
>
>
> Repository: kafka
>
>
> Description
> -------
>
> The interestOps is updated by the processor thread after the request is put in the request queue. There is no guarantee that after a request is dequeued, the read bit in interestOps is turned off. So need to wait a bit.
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala 75bd41b7d0ccbd3763e21905173f05f43f2a02f2
>
> Diff: https://reviews.apache.org/r/20787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 20787: Patch for KAFKA-1383
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20787/#review41634
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 28, 2014, 5:44 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20787/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 5:44 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1383
> https://issues.apache.org/jira/browse/KAFKA-1383
>
>
> Repository: kafka
>
>
> Description
> -------
>
> The interestOps is updated by the processor thread after the request is put in the request queue. There is no guarantee that after a request is dequeued, the read bit in interestOps is turned off. So need to wait a bit.
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/network/SocketServerTest.scala 75bd41b7d0ccbd3763e21905173f05f43f2a02f2
>
> Diff: https://reviews.apache.org/r/20787/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>