You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/10 18:32:18 UTC
[jira] [Commented] (THRIFT-3609) Remove or replace TestPortFixture.h

    [ https://issues.apache.org/jira/browse/THRIFT-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141257#comment-15141257 ] 

ASF GitHub Bot commented on THRIFT-3609:
----------------------------------------

GitHub user jsirois opened a pull request:

    https://github.com/apache/thrift/pull/841

    lib/cpp/test/SecurityTest is flaky in jenkins Thrift-precommit build.

    Previously, the server socket might not be fully closed from a prior
    test, leading to flaky port bind failures in CI.  Avoid the issue
    altogether by binding an ephemeral port.
    
    Add a TODO to TestPortFixture.h to warn folks away from its usage
    and link THRIFT-3609 to track the work of removing or replacing it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jsirois/thrift THRIFT-3608

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #841
    
----
commit d26dc7a655456c26c604cae55c42ea2770254460
Author: John Sirois <js...@apache.org>
Date:   2016-02-10T17:14:51Z

    Fixup SecurityTest to use ephemeral ports.
    
    Previously, the server socket might not be fully closed from a prior
    test, leading to flaky port bind failures in CI.  Avoid the issue
    altogether by binding an ephemeral port.
    
    Add a TODO to TestPortFixture.h to warn folks away from its usage
    and link THRIFT-3609 to track the work of removing or replacing it.

----


> Remove or replace TestPortFixture.h
> -----------------------------------
>
>                 Key: THRIFT-3609
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3609
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library, Test Suite
>            Reporter: John Sirois
>            Assignee: John Sirois
>
> Today 6 cpp lib tests use [TestPortFixture.h|https://github.com/apache/thrift/blob/1f6e380c5d07686e4cd8c2b172300a1ba7fbd8b9/lib/cpp/test/TestPortFixture.h].  THRIFT-3608 corrects one of these cases, but a general cleanup should remove all uses of static ports in the cpp tests to improve robustness and open the path to parallel testing - at least in the cpp libs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)