You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/20 18:57:14 UTC

[GitHub] [superset] etr2460 opened a new issue #12628: Certified metric icons are various sizes

etr2460 opened a new issue #12628:
URL: https://github.com/apache/superset/issues/12628


   ## Screenshot
   ![image](https://user-images.githubusercontent.com/7409244/105221516-12eb1c80-5b0e-11eb-86eb-e9f12a5ec34b.png)
   
   ## Description
   When multiple metrics are certified, it seems like the icons are different sizes. No clue why, but it seems to be introduced with the new dataset panel
   
   ## Design input
   They should all be the same size


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12628: Certified metric icons are various sizes

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12628:
URL: https://github.com/apache/superset/issues/12628#issuecomment-763866158


   @etr2460 Thanks for reporting. we are aware of this issue. icon migration project has been put on-hold until v1.0.1 release.  
   
   
   cc @geido 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #12628: Certified metric icons are various sizes

Posted by GitBox <gi...@apache.org>.
geido commented on issue #12628:
URL: https://github.com/apache/superset/issues/12628#issuecomment-765500687


   I have provided a quick fix for this as the issue is not related to the icon itself but to a styling issue, so it makes sense to keep this separate from the icons migration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ktmud closed issue #12628: Certified metric icons are various sizes

Posted by GitBox <gi...@apache.org>.
ktmud closed issue #12628:
URL: https://github.com/apache/superset/issues/12628


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #12628: Certified metric icons are various sizes

Posted by GitBox <gi...@apache.org>.
geido commented on issue #12628:
URL: https://github.com/apache/superset/issues/12628#issuecomment-764467519


   Yep. I Will check those out first as soon as we can get the initial POC for the icons in 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #12628: Certified metric icons are various sizes

Posted by GitBox <gi...@apache.org>.
geido commented on issue #12628:
URL: https://github.com/apache/superset/issues/12628#issuecomment-764467519


   Yep. I Will check those out first as soon as we can get the initial POC for the icons in 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc edited a comment on issue #12628: Certified metric icons are various sizes

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #12628:
URL: https://github.com/apache/superset/issues/12628#issuecomment-763866158


   @etr2460 Thanks for reporting. we are aware of this issue. icon migration project has been put on-hold until v1.0.1 release.  
   
   
   cc @geido @mihir174


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] junlincc commented on issue #12628: Certified metric icons are various sizes

Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12628:
URL: https://github.com/apache/superset/issues/12628#issuecomment-763866158


   @etr2460 Thanks for reporting. we are aware of this issue. icon migration project has been put on-hold until v1.0.1 release. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org