You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by danobi <gi...@git.apache.org> on 2016/12/07 20:44:24 UTC
[GitHub] trafficserver pull request #1253: TS-5084 Make logcat follow file rotation
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/1253
TS-5084 Make logcat follow file rotation
This patch makes `traffic_logcat -f` follow squid.blog even when
squid.blog is rotated. Previously, the tool did not do this at all.
This is implemented by keeping track of the _most_previous_ inode #
of squid.blog and comparing it with the most up to date value of
the inode # every now and then. If there is ever a difference, then
we close and reopen the log file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-5084
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1253
----
commit fec98f307e2813e892ce93c81401f48700573d17
Author: Daniel Xu <dl...@yahoo.com>
Date: 2016-12-07T20:34:57Z
TS-5084 Make logcat follow file rotation
This patch makes `traffic_logcat -f` follow squid.blog even when
squid.blog is rotated. Previously, the tool did not do this at all.
This is implemented by keeping track of the _most_previous_ inode #
of squid.blog and comparing it with the most up to date value of
the inode # every now and then. If there is ever a difference, then
we close and reopen the log file.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1253
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1192/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by danobi <gi...@git.apache.org>.
Github user danobi commented on the issue:
https://github.com/apache/trafficserver/pull/1253
@shinrich Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1253
Logic looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1253
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1264/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1253: TS-5084 Make logcat follow file rotation
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/1253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1253
@danobi can you squash?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1253
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1159/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1253
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1298/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1253: TS-5084 Make logcat follow file rotation
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1253
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---