You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2022/07/28 01:12:30 UTC
[doris] branch master updated: [improvement](log) Avoid too many 'not found query' warn log (#11048)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new fccc5e3097 [improvement](log) Avoid too many 'not found query' warn log (#11048)
fccc5e3097 is described below
commit fccc5e30974d614b17d8b9c50b74915817ff5514
Author: meiyi <my...@gmail.com>
AuthorDate: Thu Jul 28 09:12:25 2022 +0800
[improvement](log) Avoid too many 'not found query' warn log (#11048)
---
fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java | 5 ++++-
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java | 4 ++--
.../src/main/java/org/apache/doris/transaction/TransactionState.java | 2 +-
3 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java b/fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java
index 39a6797c91..fbf86d4347 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/QeProcessorImpl.java
@@ -89,6 +89,7 @@ public final class QeProcessorImpl implements QeProcessor {
}
}
+ @Override
public void registerInstances(TUniqueId queryId, Integer instancesNum) throws UserException {
if (!coordinatorMap.containsKey(queryId)) {
throw new UserException("query not exists in coordinatorMap:" + DebugUtil.printId(queryId));
@@ -143,7 +144,9 @@ public final class QeProcessorImpl implements QeProcessor {
}
}
} else {
- LOG.warn("not found query {} when unregisterQuery", DebugUtil.printId(queryId));
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("not found query {} when unregisterQuery", DebugUtil.printId(queryId));
+ }
}
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java b/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
index b092cab722..45f9ff3529 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
@@ -476,8 +476,6 @@ public class StmtExecutor implements ProfileWriter {
LOG.warn("handle insert stmt fail", t);
// the transaction of this insert may already begun, we will abort it at outer finally block.
throw t;
- } finally {
- QeProcessorImpl.INSTANCE.unregisterQuery(context.queryId());
}
} else if (parsedStmt instanceof DdlStmt) {
handleDdlStmt();
@@ -1438,6 +1436,8 @@ public class StmtExecutor implements ProfileWriter {
* which exactly like the old insert stmt usage pattern.
*/
throwable = t;
+ } finally {
+ QeProcessorImpl.INSTANCE.unregisterQuery(context.queryId());
}
// Go here, which means:
diff --git a/fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionState.java b/fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionState.java
index e444813eac..9374a2eeb3 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionState.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/transaction/TransactionState.java
@@ -207,7 +207,7 @@ public class TransactionState implements Writable {
// 2. callback object has been removed from CallbackFactory
// 3. in afterStateTransform(), callback object can not be found, so the write lock can not be released.
private TxnStateChangeCallback callback = null;
- private long timeoutMs = Config.stream_load_default_timeout_second;
+ private long timeoutMs = Config.stream_load_default_timeout_second * 1000;
private long preCommittedTimeoutMs = Config.stream_load_default_precommit_timeout_second * 1000;
private String authCode = "";
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org