[GitHub] [hadoop] jojochuang commented on a change in pull request #3491: HDFS-16239. XAttr#toString doesnt print the attribute value in readab…

[GitBox <gi...@apache.org>]

jojochuang commented on a change in pull request #3491:
URL: https://github.com/apache/hadoop/pull/3491#discussion_r719145598



##########
File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/fs/XAttr.java
##########
@@ -158,6 +158,6 @@ public boolean equalsIgnoreValue(Object obj) {
   @Override
   public String toString() {
     return "XAttr [ns=" + ns + ", name=" + name + ", value="
-        + Arrays.toString(value) + "]";
+        + new String(value, Charset.defaultCharset()) + "]";

Review comment:
       agreed, xattr is not necessarily printable. For example, encryption zone file EDEK. To print, have we considered using XattrCodec APIs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org