You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Joob1n (via GitHub)" <gi...@apache.org> on 2026/09/23 04:21:59 UTC
[PR] fix(export): abandon interrupted user questions [maka]
Joob1n opened a new pull request, #5610:
URL: https://github.com/apache/maka/pull/5610
## Summary
An interrupted `AskUserQuestion` can leave a prepared tool-operation projection after its invocation has already terminated, blocking session export. Rebuild the disposable projections from canonical runtime events and mark only terminal unanswered questions as abandoned. Live invocations and potentially side-effecting tools remain unsettled, and no synthetic tool response is added.
## Verification
- `npm --workspace @maka/storage run build` — passed.
- `npm --workspace @maka/runtime-host run build` — passed.
- `node --test --test-name-pattern='abandoned|live invocation|never settled' packages/runtime/dist/__tests__/session-export.test.js` — 4 passed.
- `npm --workspace @maka/runtime run build` — blocked by four unrelated implicit-`any` errors in test files.
- Repository-wide lint, format, and typecheck were not run.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex authored the implementation, regression tests, and this description.
## Checklist
- [x] Tests cover the change and fail without it
- [ ] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — terminal interrupted unanswered questions no longer block export; live or side-effecting unsettled operations still do.
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(runtime): settle interrupted tools before terminal events [maka]
Posted by "orangeCatDeveloper (via GitHub)" <gi...@apache.org>.
orangeCatDeveloper commented on PR #5610:
URL: https://github.com/apache/maka/pull/5610#issuecomment-5790132262
CI is still failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(export): abandon interrupted user questions [maka]
Posted by "orangeCatDeveloper (via GitHub)" <gi...@apache.org>.
orangeCatDeveloper commented on code in PR #5610:
URL: https://github.com/apache/maka/pull/5610#discussion_r4079056644
##########
packages/storage/src/session-bundle-policy.ts:
##########
@@ -478,6 +479,15 @@ async function filterBackedUpDatabase(
sessionIds: readonly string[],
options: { omitDiagnostics: boolean; requireQuiescent: boolean },
): Promise<void> {
+ const runtimeStore = createSqliteRuntimeStore(destinationPath);
Review Comment:
**[P1] Avoid rebuilding all tool projections during every export**
`rebuildToolProjectionsForSession()` decodes every runtime event in the session. Existing legacy or byte-preservation records that do not match the latest `RuntimeEvent` schema now cause exports to fail with `Invalid RuntimeEvent schema`, sometimes replacing the expected `session_active` result with `io_failed`.
This breaks seven existing export/import tests, including session round-tripping and active-session detection, and the current CI fails for the same reason. Please limit rebuilding to candidate stale `AskUserQuestion` projections, or otherwise preserve unrelated historical events without decoding them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(runtime): settle interrupted tools before terminal events [maka]
Posted by "Joob1n (via GitHub)" <gi...@apache.org>.
Joob1n merged PR #5610:
URL: https://github.com/apache/maka/pull/5610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org