You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2010/04/17 19:38:16 UTC

Re: [PATCH] Use a node func for fetching file external status in libsvn_client/delete.c

Dude. Totally fine. I wrote that function last week for exactly what you're
doing.

On Apr 17, 2010 2:10 PM, "Daniel Näslund" <da...@longitudo.com> wrote:

Hi!

This patch passes make check.

svn_wc__node_is_file_external() seems to be in a bit of a flux yet. Is
it ok to commit this one?

[[[
As part of WC-NG, remove a usage of svn_wc_entry_t.

* subversion/libsvn_client/delete.c
 (svn_client__can_delete): Use svn_wc__node_is_file_external() instead
   of checking the entry.
]]]

Re: [PATCH] Use a node func for fetching file external status in libsvn_client/delete.c

Posted by Daniel Näslund <da...@longitudo.com>.

On Sat, Apr 17, 2010 at 03:38:16PM -0400, Greg Stein wrote:
> Dude. Totally fine. I wrote that function last week for exactly what you're
> doing.
> 
> On Apr 17, 2010 2:10 PM, "Daniel Näslund" <da...@longitudo.com> wrote:
> 
> Hi!
> 
> This patch passes make check.
> 
> svn_wc__node_is_file_external() seems to be in a bit of a flux yet. Is
> it ok to commit this one?
> 
> [[[
> As part of WC-NG, remove a usage of svn_wc_entry_t.
> 
> * subversion/libsvn_client/delete.c
>  (svn_client__can_delete): Use svn_wc__node_is_file_external() instead
>    of checking the entry.
> ]]]

Committed in r935314.

Re: [PATCH] Use a node func for fetching file external status in libsvn_client/delete.c

Posted by Daniel Näslund <da...@longitudo.com>.

On Sat, Apr 17, 2010 at 03:38:16PM -0400, Greg Stein wrote:
> Dude. Totally fine. I wrote that function last week for exactly what you're
> doing.
> 
> On Apr 17, 2010 2:10 PM, "Daniel Näslund" <da...@longitudo.com> wrote:
> 
> Hi!
> 
> This patch passes make check.
> 
> svn_wc__node_is_file_external() seems to be in a bit of a flux yet. Is
> it ok to commit this one?
> 
> [[[
> As part of WC-NG, remove a usage of svn_wc_entry_t.
> 
> * subversion/libsvn_client/delete.c
>  (svn_client__can_delete): Use svn_wc__node_is_file_external() instead
>    of checking the entry.
> ]]]

Committed in r935314.