You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/09 09:06:30 UTC
[GitHub] [iceberg] Fokko opened a new issue, #6156: Python: Fix the explicit annotations of Reference
Fokko opened a new issue, #6156:
URL: https://github.com/apache/iceberg/issues/6156
### Feature Request / Improvement
https://github.com/apache/iceberg/pull/6139#issuecomment-1307812458
I did notice some funky behavior with the type system. When using a `Reference(UnboundTerm[T])` mypy it is unable to determine the type `T`, since there is no type information. This requires annotating this by hand `Reference[int]("id")`. I think we should only add this type to bound terms or find another way to let Python/mypy figure out the type.
### Query engine
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on issue #6156: Python: Fix the explicit annotations of Reference
Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #6156:
URL: https://github.com/apache/iceberg/issues/6156#issuecomment-1308500288
For the bound ones, I think the key is in the literal method. Turning:
```python
@singledispatch
def literal(value) -> Literal:
```
Into:
```python
@singledispatch
def literal(value: T) -> Literal[T]:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on issue #6156: Python: Re-enable the typesystem
Posted by GitBox <gi...@apache.org>.
Fokko commented on issue #6156:
URL: https://github.com/apache/iceberg/issues/6156#issuecomment-1329075739
This has been done, I'll close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko closed issue #6156: Python: Re-enable the typesystem
Posted by GitBox <gi...@apache.org>.
Fokko closed issue #6156: Python: Re-enable the typesystem
URL: https://github.com/apache/iceberg/issues/6156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org