You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/11 23:09:55 UTC
[GitHub] jmeter pull request #357: Refactoring/formatting in preparation for alternat...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/357
Refactoring/formatting in preparation for alternate menu sorting
## Description
Refactoring/formatting in preparation for alternate menu sorting
## How Has This Been Tested?
Looking through each menu in the UI
## Checklist:
- [x] My code follows the [code style][style-guide] of this project.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter menu_refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #357
----
commit aa4d3d922953815de6a700236fd88f744edf099f
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-12-10T18:06:16Z
refactoring/formatting in preparation for alternate menu sorting
----
---
[GitHub] jmeter issue #357: Refactoring/formatting in preparation for alternate menu ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/357
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/357?src=pr&el=h1) Report
> Merging [#357](https://codecov.io/gh/apache/jmeter/pull/357?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/427907f9d2ca45f8077acf9398a140834d75e3bd?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/jmeter/pull/357?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #357 +/- ##
============================================
- Coverage 58.19% 58.18% -0.01%
+ Complexity 10210 10209 -1
============================================
Files 1161 1161
Lines 74189 74191 +2
Branches 7322 7319 -3
============================================
- Hits 43174 43170 -4
- Misses 28517 28523 +6
Partials 2498 2498
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/357?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...eter/protocol/http/config/gui/HttpDefaultsGui.java](https://codecov.io/gh/apache/jmeter/pull/357/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb25maWcvZ3VpL0h0dHBEZWZhdWx0c0d1aS5qYXZh) | `80.78% <ø> (ø)` | `21 <0> (ø)` | :arrow_down: |
| [...r/protocol/http/control/gui/HttpTestSampleGui.java](https://codecov.io/gh/apache/jmeter/pull/357/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL2d1aS9IdHRwVGVzdFNhbXBsZUd1aS5qYXZh) | `85.71% <ø> (ø)` | `24 <0> (ø)` | :arrow_down: |
| [src/core/org/apache/jmeter/gui/MainFrame.java](https://codecov.io/gh/apache/jmeter/pull/357/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL01haW5GcmFtZS5qYXZh) | `1.54% <0%> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...c/core/org/apache/jmeter/gui/util/MenuFactory.java](https://codecov.io/gh/apache/jmeter/pull/357/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvZ3VpL3V0aWwvTWVudUZhY3RvcnkuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...mpler/hc/JMeterPoolingClientConnectionManager.java](https://codecov.io/gh/apache/jmeter/pull/357/diff?src=pr&el=tree#diff-c3JjL3Byb3RvY29sL2h0dHAvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL2hjL0pNZXRlclBvb2xpbmdDbGllbnRDb25uZWN0aW9uTWFuYWdlci5qYXZh) | `27.77% <0%> (-3.18%)` | `10% <0%> (-1%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/357?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/357?src=pr&el=footer). Last update [427907f...aa4d3d9](https://codecov.io/gh/apache/jmeter/pull/357?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter pull request #357: Refactoring/formatting in preparation for alternat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/357
---