You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "lokeshj1703 (via GitHub)" <gi...@apache.org> on 2023/02/13 11:52:05 UTC
[GitHub] [hudi] lokeshj1703 opened a new pull request, #7933: Add labels to prometheus
lokeshj1703 opened a new pull request, #7933:
URL: https://github.com/apache/hudi/pull/7933
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Support for adding labels to prometheus metrics
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1428359395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62dd45b5f189526ba0595abb566c38ed3bcadad6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Support for adding labels to prometheus metrics
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1427874194
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62dd45b5f189526ba0595abb566c38ed3bcadad6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1431998606
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f36de2e745401f48980bbe71513c40efaa83ac5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #7933:
URL: https://github.com/apache/hudi/pull/7933#discussion_r1108723845
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayMetricsReporter.java:
##########
@@ -77,4 +83,11 @@ private String getJobName() {
}
return configuredJobName;
}
+
+ private static Map<String, String> parseLabels(String labels) {
+ return Pattern.compile("\\s*,\\s*")
+ .splitAsStream(labels.trim())
+ .map(s -> s.split(":", 2))
Review Comment:
What if labels are not in the format `key:value`? Should we add a validation or handle this scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #7933:
URL: https://github.com/apache/hudi/pull/7933#discussion_r1109412024
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayMetricsReporter.java:
##########
@@ -77,4 +83,11 @@ private String getJobName() {
}
return configuredJobName;
}
+
+ private static Map<String, String> parseLabels(String labels) {
+ return Pattern.compile("\\s*,\\s*")
+ .splitAsStream(labels.trim())
+ .map(s -> s.split(":", 2))
Review Comment:
Currently the way it behaves, it will convert input like
```
"hudi:prometheus" -> "hudi" and "prometheus"
"hudi:prome:theus" -> "hudi" and "prome:theus"
"hudiprometheus" -> "hudiprometheus" and ""
```
This looks fine to me or do we want more stricter rules here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #7933:
URL: https://github.com/apache/hudi/pull/7933#discussion_r1108740795
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -329,9 +330,18 @@ private HoodieWriteConfig createMetadataWriteConfig(
.toJmxHost(writeConfig.getJmxHost())
.build());
break;
+ case PROMETHEUS_PUSHGATEWAY:
+ HoodieMetricsPrometheusConfig prometheusConfig = HoodieMetricsPrometheusConfig.newBuilder()
+ .withPushgatewayJobname(writeConfig.getPushGatewayJobName())
+ .withPushgatewayRandomJobnameSuffix(writeConfig.getPushGatewayRandomJobNameSuffix())
+ .withPushgatewayLabels(writeConfig.getPushGatewayLabels())
+ .withPushgatewayReportPeriodInSeconds(String.valueOf(writeConfig.getPushGatewayReportPeriodSeconds()))
+ .withPushgatewayHostName(writeConfig.getPushGatewayHost())
+ .withPushgatewayPortNum(writeConfig.getPushGatewayPort()).build();
+ builder.withProps(prometheusConfig.getProps());
Review Comment:
can use `builder.withProperties`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayMetricsReporter.java:
##########
@@ -77,4 +83,11 @@ private String getJobName() {
}
return configuredJobName;
}
+
+ private static Map<String, String> parseLabels(String labels) {
+ return Pattern.compile("\\s*,\\s*")
+ .splitAsStream(labels.trim())
+ .map(s -> s.split(":", 2))
Review Comment:
What if labels are not in the format key:value? Should we add a validation or handle this scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1431234245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a02b393674ed4ae07d1eed67560f126ac06e178c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158)
* 638327ab8184a7b40d379bd8591f9e67f7fe70f7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196)
* 6f36de2e745401f48980bbe71513c40efaa83ac5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1433045696
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f36de2e745401f48980bbe71513c40efaa83ac5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206)
* 4a9306d5714dee2af55bc0a5a3589f5dda1668f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1433747515
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a9306d5714dee2af55bc0a5a3589f5dda1668f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1435427031
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277",
"triggerID" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2c49dd15a65110f9a336d36b7de1954f62a1f7b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1430886430
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a02b393674ed4ae07d1eed67560f126ac06e178c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158)
* 638327ab8184a7b40d379bd8591f9e67f7fe70f7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Support for adding labels to prometheus metrics
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1429515776
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62dd45b5f189526ba0595abb566c38ed3bcadad6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140)
* a02b393674ed4ae07d1eed67560f126ac06e178c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1434680377
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a9306d5714dee2af55bc0a5a3589f5dda1668f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242)
* d2c49dd15a65110f9a336d36b7de1954f62a1f7b UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1434689044
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277",
"triggerID" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4a9306d5714dee2af55bc0a5a3589f5dda1668f9 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242)
* d2c49dd15a65110f9a336d36b7de1954f62a1f7b Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1436885266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277",
"triggerID" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"triggerType" : "PUSH"
}, {
"hash" : "bee3e29c68a3884332a577a8d711d93e8f109add",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15295",
"triggerID" : "bee3e29c68a3884332a577a8d711d93e8f109add",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2c49dd15a65110f9a336d36b7de1954f62a1f7b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277)
* bee3e29c68a3884332a577a8d711d93e8f109add Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15295)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #7933:
URL: https://github.com/apache/hudi/pull/7933#discussion_r1109607877
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayMetricsReporter.java:
##########
@@ -77,4 +83,11 @@ private String getJobName() {
}
return configuredJobName;
}
+
+ private static Map<String, String> parseLabels(String labels) {
+ return Pattern.compile("\\s*,\\s*")
+ .splitAsStream(labels.trim())
+ .map(s -> s.split(":", 2))
Review Comment:
Ok. Can you add a UT for multiple key value pairs as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1431242582
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 638327ab8184a7b40d379bd8591f9e67f7fe70f7 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196)
* 6f36de2e745401f48980bbe71513c40efaa83ac5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1430892893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a02b393674ed4ae07d1eed67560f126ac06e178c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158)
* 638327ab8184a7b40d379bd8591f9e67f7fe70f7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1436863778
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15242",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277",
"triggerID" : "d2c49dd15a65110f9a336d36b7de1954f62a1f7b",
"triggerType" : "PUSH"
}, {
"hash" : "bee3e29c68a3884332a577a8d711d93e8f109add",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bee3e29c68a3884332a577a8d711d93e8f109add",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2c49dd15a65110f9a336d36b7de1954f62a1f7b Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15277)
* bee3e29c68a3884332a577a8d711d93e8f109add UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "codope (via GitHub)" <gi...@apache.org>.
codope merged PR #7933:
URL: https://github.com/apache/hudi/pull/7933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Support for adding labels to prometheus metrics
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1427864275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62dd45b5f189526ba0595abb566c38ed3bcadad6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1433035018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
}, {
"hash" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15196",
"triggerID" : "638327ab8184a7b40d379bd8591f9e67f7fe70f7",
"triggerType" : "PUSH"
}, {
"hash" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206",
"triggerID" : "6f36de2e745401f48980bbe71513c40efaa83ac5",
"triggerType" : "PUSH"
}, {
"hash" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4a9306d5714dee2af55bc0a5a3589f5dda1668f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6f36de2e745401f48980bbe71513c40efaa83ac5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15206)
* 4a9306d5714dee2af55bc0a5a3589f5dda1668f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Support for adding labels to prometheus metrics
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1429506010
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 62dd45b5f189526ba0595abb566c38ed3bcadad6 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140)
* a02b393674ed4ae07d1eed67560f126ac06e178c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7933:
URL: https://github.com/apache/hudi/pull/7933#issuecomment-1430119513
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15140",
"triggerID" : "62dd45b5f189526ba0595abb566c38ed3bcadad6",
"triggerType" : "PUSH"
}, {
"hash" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158",
"triggerID" : "a02b393674ed4ae07d1eed67560f126ac06e178c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a02b393674ed4ae07d1eed67560f126ac06e178c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15158)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lokeshj1703 commented on a diff in pull request #7933: [HUDI-5774] Fix prometheus configs for metadata table and support metric labels
Posted by "lokeshj1703 (via GitHub)" <gi...@apache.org>.
lokeshj1703 commented on code in PR #7933:
URL: https://github.com/apache/hudi/pull/7933#discussion_r1109829058
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metrics/prometheus/PushGatewayMetricsReporter.java:
##########
@@ -77,4 +83,11 @@ private String getJobName() {
}
return configuredJobName;
}
+
+ private static Map<String, String> parseLabels(String labels) {
+ return Pattern.compile("\\s*,\\s*")
+ .splitAsStream(labels.trim())
+ .map(s -> s.split(":", 2))
Review Comment:
Added in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org