You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/06/03 01:03:36 UTC
[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin
Hello David Ribeiro Alves, Grant Henke, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7070
to review the following change.
Change subject: [java-client] update protoc maven plugin
......................................................................
[java-client] update protoc maven plugin
The current protoc maven plugin is not hosted on maven central
and the hosting domain is unavailable. It also has not been
updated since 2012.
It appears like the most current and maintained fork is
here: https://github.com/xolstice/protobuf-maven-plugin
Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Reviewed-on: http://gerrit.cloudera.org:8080/6830
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M java/kudu-client/pom.xml
M java/pom.xml
2 files changed, 12 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/7070/1
--
To view, visit http://gerrit.cloudera.org:8080/7070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: [java-client] update protoc maven plugin
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [java-client] update protoc maven plugin
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR](branch-1.3.x) [java-client] update protoc maven plugin
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [java-client] update protoc maven plugin
......................................................................
[java-client] update protoc maven plugin
The current protoc maven plugin is not hosted on maven central
and the hosting domain is unavailable. It also has not been
updated since 2012.
It appears like the most current and maintained fork is
here: https://github.com/xolstice/protobuf-maven-plugin
Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Reviewed-on: http://gerrit.cloudera.org:8080/6830
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Reviewed-on: http://gerrit.cloudera.org:8080/7070
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M java/kudu-client/pom.xml
M java/pom.xml
2 files changed, 12 insertions(+), 18 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43167c298e5230cd6421fd992f712513f8801b5a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins