You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Pascal Schumacher <pa...@gmx.net> on 2016/12/21 10:48:48 UTC

[Lang] Deprecate SystemUtils#LINE_SEPARATOR

Hello everybody,

what about deprecating SystemUtils#LINE_SEPARATOR in favor of 
System#lineSeparator?

I suggest we deprecated it with the following explanation:

"Use {@link System#lineSeparator} instead, since it can not be null and 
does not require a privilege check." (I'm not 100% sure about the null 
part, but did not find any information contradicting it.)

What do you think?

Thanks,

Pascal




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [Lang] Deprecate SystemUtils#LINE_SEPARATOR

Posted by Gary Gregory <ga...@gmail.com>.
On Wed, Dec 21, 2016 at 6:37 AM, Jochen Wiedmann <jo...@gmail.com>
wrote:

> How about we change LINE_SEPARATOR instead to be initialized via
> System.lineSeparator instead, so that it cannot be null instead? From
> reading System.initializeSystemClass(), my guess is they are the same
> anyways.
>

Seems OK.

Gary


>
> Jochen
>
>
> On Wed, Dec 21, 2016 at 11:48 AM, Pascal Schumacher
> <pa...@gmx.net> wrote:
> > Hello everybody,
> >
> > what about deprecating SystemUtils#LINE_SEPARATOR in favor of
> > System#lineSeparator?
> >
> > I suggest we deprecated it with the following explanation:
> >
> > "Use {@link System#lineSeparator} instead, since it can not be null and
> does
> > not require a privilege check." (I'm not 100% sure about the null part,
> but
> > did not find any information contradicting it.)
> >
> > What do you think?
> >
> > Thanks,
> >
> > Pascal
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
>
>
> --
> The next time you hear: "Don't reinvent the wheel!"
>
> http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/
> evolution-of-the-wheel-300x85.jpg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
JUnit in Action, Second Edition
<https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>

<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
Spring Batch in Action
<https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
<http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [Lang] Deprecate SystemUtils#LINE_SEPARATOR

Posted by Jochen Wiedmann <jo...@gmail.com>.
How about we change LINE_SEPARATOR instead to be initialized via
System.lineSeparator instead, so that it cannot be null instead? From
reading System.initializeSystemClass(), my guess is they are the same
anyways.

Jochen


On Wed, Dec 21, 2016 at 11:48 AM, Pascal Schumacher
<pa...@gmx.net> wrote:
> Hello everybody,
>
> what about deprecating SystemUtils#LINE_SEPARATOR in favor of
> System#lineSeparator?
>
> I suggest we deprecated it with the following explanation:
>
> "Use {@link System#lineSeparator} instead, since it can not be null and does
> not require a privilege check." (I'm not 100% sure about the null part, but
> did not find any information contradicting it.)
>
> What do you think?
>
> Thanks,
>
> Pascal
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>



-- 
The next time you hear: "Don't reinvent the wheel!"

http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org