You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org> on 2026/04/21 14:33:17 UTC
[PR] [core] Skip partition-specific table-default options for non-partitioned tables [paimon]
XiaoHongbo-Hope opened a new pull request, #7681:
URL: https://github.com/apache/paimon/pull/7681
…ned tables
### Purpose
### Tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Skip partition-specific table-default options for non-partitioned tables [paimon]
Posted by "XiaoHongbo-Hope (via GitHub)" <gi...@apache.org>.
XiaoHongbo-Hope commented on code in PR #7681:
URL: https://github.com/apache/paimon/pull/7681#discussion_r3141939529
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -204,10 +204,13 @@ public static void validateTableSchema(TableSchema schema) {
CoreOptions.STREAMING_READ_APPEND_OVERWRITE.key()));
}
- if (schema.options().containsKey(CoreOptions.PARTITION_EXPIRATION_TIME.key())) {
- if (schema.partitionKeys().isEmpty()) {
+ if (schema.partitionKeys().isEmpty()) {
+ for (String key : schema.options().keySet()) {
+ if (!CoreOptions.requiresPartitionedTable(key)) {
+ continue;
+ }
throw new IllegalArgumentException(
- "Can not set 'partition.expiration-time' for non-partitioned table.");
Review Comment:
> Just remove this?
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Skip partition-specific table-default options for non-partitioned tables [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #7681:
URL: https://github.com/apache/paimon/pull/7681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Skip partition-specific table-default options for non-partitioned tables [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #7681:
URL: https://github.com/apache/paimon/pull/7681#issuecomment-4321430035
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [core] Skip partition-specific table-default options for non-partitioned tables [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #7681:
URL: https://github.com/apache/paimon/pull/7681#discussion_r3136812025
##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java:
##########
@@ -204,10 +204,13 @@ public static void validateTableSchema(TableSchema schema) {
CoreOptions.STREAMING_READ_APPEND_OVERWRITE.key()));
}
- if (schema.options().containsKey(CoreOptions.PARTITION_EXPIRATION_TIME.key())) {
- if (schema.partitionKeys().isEmpty()) {
+ if (schema.partitionKeys().isEmpty()) {
+ for (String key : schema.options().keySet()) {
+ if (!CoreOptions.requiresPartitionedTable(key)) {
+ continue;
+ }
throw new IllegalArgumentException(
- "Can not set 'partition.expiration-time' for non-partitioned table.");
Review Comment:
Just remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org