You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by shweta agarwal <sh...@citrix.com> on 2015/03/16 10:23:12 UTC
Review Request 32094: test case added to verify restore VM operation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32094/
-----------------------------------------------------------
Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
Repository: cloudstack-git
Description
-------
test case added to verify restore VM operation
Diffs
-----
test/integration/component/test_escalations_instances.py 4b22016
tools/marvin/marvin/config/test_data.py 80ead64
Diff: https://reviews.apache.org/r/32094/diff/
Testing
-------
Yes
Thanks,
shweta agarwal
Re: Review Request 32094: test case added to verify restore VM
operation
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32094/#review76540
-----------------------------------------------------------
test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/32094/#comment124110>
Please keep specific imports rather than import *
test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/32094/#comment124111>
Not sure if we running/skipping tests on specific hypervisor depending uppon tags. Can you add a condition in the test case?
test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/32094/#comment124113>
Please remove pep8 issues
test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/32094/#comment124112>
Please use validateList method fomr utils.py
test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/32094/#comment124115>
Please read host credentails from configurableData section in test_data.py file
test/integration/component/test_escalations_instances.py
<https://reviews.apache.org/r/32094/#comment124116>
No need to sleep as the check is included in base library, check VirtualMachine.start() function
tools/marvin/marvin/config/test_data.py
<https://reviews.apache.org/r/32094/#comment124117>
Will this work on automated builds?
tools/marvin/marvin/config/test_data.py
<https://reviews.apache.org/r/32094/#comment124118>
Unwanted change?
- Gaurav Aradhye
On March 16, 2015, 2:53 p.m., shweta agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32094/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 2:53 p.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> test case added to verify restore VM operation
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py 4b22016
> tools/marvin/marvin/config/test_data.py 80ead64
>
> Diff: https://reviews.apache.org/r/32094/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> shweta agarwal
>
>
Re: Review Request 32094: test case added to verify restore VM
operation
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32094/#review78978
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On March 16, 2015, 9:23 a.m., shweta agarwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32094/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 9:23 a.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> test case added to verify restore VM operation
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_instances.py 4b22016
> tools/marvin/marvin/config/test_data.py 80ead64
>
> Diff: https://reviews.apache.org/r/32094/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> shweta agarwal
>
>