[jira] [Commented] (LUCENE-9504) DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking

["Simon Willnauer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191579#comment-17191579 ] 

Simon Willnauer commented on LUCENE-9504:
-----------------------------------------

there is no need for measuring impact. This is a leftover I think. It's only used in tests anyway.

> DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-9504
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9504
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{DocumentsWriterDeleteQueue.forceApplyGlobalSlice}} is only called from {{getBufferedUpdateTermsSize}} so we end up doing double the locking. It's not a huge problem because re-entrant locks are cheap, but we can probably unwrap the methods a little bit here.
> This may impact HotSpot inlining, I haven't tried measuring that yet. If that is a concern, please let me know.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org