You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/06/24 16:12:34 UTC

[GitHub] [hudi] sbernauer commented on a change in pull request #3111: [HUDI-2069] Fix KafkaAvroSchemaDeserializer to not rely on reflection

sbernauer commented on a change in pull request #3111:
URL: https://github.com/apache/hudi/pull/3111#discussion_r658090982



##########
File path: hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DataSourceOptions.scala
##########
@@ -382,8 +382,6 @@ object DataSourceWriteOptions {
 
   // Avro Kafka Source configs
   val KAFKA_AVRO_VALUE_DESERIALIZER = "hoodie.deltastreamer.source.kafka.value.deserializer.class"
-
-  // Schema provider class to be set to be used in custom kakfa deserializer
-  val SCHEMA_PROVIDER_CLASS_PROP = "hoodie.deltastreamer.schemaprovider.class"

Review comment:
       Both settings (old and new) are not set via config. Bot are calculated and (over)written by Deltastreamer itself. They are used to pass things around.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org