You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/17 13:39:51 UTC

[GitHub] [hudi] yadav-jai opened a new pull request, #5609: Fixed styling and responsiveness

yadav-jai opened a new pull request, #5609:
URL: https://github.com/apache/hudi/pull/5609

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   Fixed the blog page header and made the navbar responsive after addition of blogs . 
   
   <img width="1083" alt="Screenshot 2022-05-17 at 7 09 05 PM" src="https://user-images.githubusercontent.com/97013124/168824433-0bc15f4a-df3b-4fac-84e5-d6b746e7f29a.png">
   
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] bhasudha merged pull request #5609: Fixed styling and responsiveness

Posted by GitBox <gi...@apache.org>.
bhasudha merged PR #5609:
URL: https://github.com/apache/hudi/pull/5609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] bhasudha commented on a diff in pull request #5609: Fixed styling and responsiveness

Posted by GitBox <gi...@apache.org>.
bhasudha commented on code in PR #5609:
URL: https://github.com/apache/hudi/pull/5609#discussion_r875187784


##########
website/src/theme/BlogPostItem/styles.module.css:
##########
@@ -5,9 +5,12 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-.blogPostTitle {
+ .blogPostTitle {
   font-size: 1rem;
 }
+.blogPostPageTile{

Review Comment:
   Still there is a minor issue when rendering long title in the individual blog pages. Please open a separate PR and address that. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org