You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/12/20 23:41:59 UTC
[jira] [Commented] (CB-10799) Toolbar is shown in incorrect
position if inappbrowser is shown when in-call status bar is active
[ https://issues.apache.org/jira/browse/CB-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765589#comment-15765589 ]
ASF GitHub Bot commented on CB-10799:
-------------------------------------
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/203
CB-10799 (ios) fix toolbar in incorrect position when in-call status bar
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Fix the incorrect position of the toolbar when the inAppBrowser is presented while in-call status bar is show.
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-inappbrowser CB-10799
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/203.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #203
----
commit a0bcc6a48d39d1eb8689a799f51fbbd8b55036d1
Author: Julio César <jc...@gmail.com>
Date: 2016-12-20T23:39:25Z
CB-10799 (ios) fix toolbar is shown in incorrect position when in-call status bar
----
> Toolbar is shown in incorrect position if inappbrowser is shown when in-call status bar is active
> -------------------------------------------------------------------------------------------------
>
> Key: CB-10799
> URL: https://issues.apache.org/jira/browse/CB-10799
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS, Plugin InAppBrowser
> Affects Versions: 1.3.0
> Reporter: Martin Baker
> Assignee: jcesarmobile
> Priority: Minor
> Labels: ios, reproduced, triaged
> Attachments: 1.png, 2.png, 3.png, 4.png, 5.png, 6.png, 7.png, 8.png
>
>
> If the in-call status bar is active when an inappbrowser is shown, and toolbar is set to top, then the toolbar is positioned 20pt lower than it should be and partially covers up the webview.
> This does not happen if the inappbrowser is shown and *then* the in-call status bar is shown.
> A similar but related problem happens if the toolbar is positioned at the bottom - there is a 20pt gap between the in-call status bar and the top of the webview. This suggests the issue is happening because the parent view is wrongly positioned 20pt lower than it should be in this situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org